revert to legacy color chooser for pixel/beam #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The better option would be to make a custom dialog for the pixel that integrates a colour picker as well as a custom slider for the wireless frequency, which would also fix things like the colour not showing up in the preview box because the alpha is 0 by default dear god why did they ever decide to use the alpha value for wireless frequency... But this works for now yeah. It's deprecated but I honestly prefer this dialog over the "new" one for all other colour pickers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #160
switch back to legacy color picker for pixel as the new one does not allow precisely selecting (and does not show) alpha channel value.
This also affects the Plastic Beam dialog since they both reuse the same instance, but... eh, who cares.
Would've been nice to revert everything for the sake of consistency but
GtkColorButtononly works with the newGtkColorChooserso it's not possible