-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robot Manager targetting an absorbed robot crashes the game on Windows with certain inputs #152
Comments
i think this is another use after free...?
|
Yes, obviously. |
seems like the Robot Manager never receives |
seems like subscriptions get reset??? between initialization and actual absorb. |
Lines 839 to 845 in 87b00fb
... interesting... Commenting out the following lines in the // this->listeners.clear();
// this->subscriptions.clear(); But I'm pretty sure this has some unintended side effects... By the way, saving and reloading the state before the robot is absorbed causes the game to not crash, since Lines 560 to 578 in 87b00fb
|
Principia version
1.5.2 Beta build 2023-12-26
OS / Hardware
Summary
Here is a table of Inputs that crash the game when the controlled robot gets absorbed.
❌: The game doesn't crash
✅: The game crashes
* For IN18, the robot under control doesn't fall.
There are some additional set of conditions to crash the game.
To crash the game, one of these conditions below must be satisfied.
Steps to reproduce
Empty Adventure
level.1.0
.The text was updated successfully, but these errors were encountered: