Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulnerable Settings for DoS Attack #452

Open
CharesFang opened this issue Dec 6, 2021 · 1 comment
Open

Vulnerable Settings for DoS Attack #452

CharesFang opened this issue Dec 6, 2021 · 1 comment

Comments

@CharesFang
Copy link

This issue backports for Bitcoin PR#16152. There is an inappropriate setting that was founded recently in path src/validation.h.

According to the original PR#16152 of Bitcoin shown below, the NODE_BLOOM service flag is added as default and it should be disabled for security considerations.

BIP 37 bloom filters have been well-known to be a significant Do target for some time. However, in order to provide continuity for SPV clients relying on it, the NODE_BLOOM service flag was added, and left as a default, to ensure sufficient nodes exist with such a flag.

For more details, please refer to the Bitcoin original commit 5efcb772.

Reported by de957ad9679f28a38f02f00cc7928bce8fb424882ff060a3c09c32895b1474cc.
@CharesFang
Copy link
Author

  • The Bitcoin PR#16251 should also be backported for improve signrawtransaction error reporting.

ftrader pushed a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this issue Nov 30, 2022
@cculianu
Follow-up to merge of MR1600 -- some small nits
70115a2 
Co-authored-by: Andrew-128 <[email protected]>

Summary
---

Andrew-128 suggested a few nits to 1600 but we had already frozen that
MR.  This follow-up are his suggestions.  Closes issue Bitcoin-ABC#452.

Test Plan
---

- `ninja all check`
- Ensure the issue comments in Bitcoin-ABC#452 are all addressed, more-or-less.
ftrader added a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this issue Nov 30, 2022
@ftrader
Merge branch 'mr_1600_followup_nits_1' into 'master'
779fccd 
Follow-up to merge of MR1600 -- some small nits

Closes Bitcoin-ABC#452

See merge request bitcoin-cash-node/bitcoin-cash-node!1642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CharesFang and others