Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui-ux): make ocean endpoint configurable via env #1938

Merged
merged 6 commits into from
Sep 11, 2024
Merged

chore(ui-ux): make ocean endpoint configurable via env #1938

merged 6 commits into from
Sep 11, 2024

Conversation

pierregee
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Sample Links & Screenshots:

Link:

Desktop Screenshot
Mobile Screenshot

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Tested on multiple web browsers
  • Tested responsiveness (e.g, iPhone, iPad, Desktop)
  • No console errors
  • Unit tests*
  • Added e2e tests*

@github-actions github-actions bot added area/layouts kind/chore Non feature change labels Jul 18, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 18, 2024 •
edited
Loading

✅ Deploy Preview for defi-scan ready!

Name Link
🔨 Latest commit bb55202
🔍 Latest deploy log https://app.netlify.com/sites/defi-scan/deploys/66e11b36e192d700084147ca
😎 Deploy Preview https://deploy-preview-1938--defi-scan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 35 (🔴 down 5 from production)
Accessibility: 75 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chloezxyy
Copy link
Contributor

LGTM

@pierregee pierregee merged commit b618a70 into main Sep 11, 2024
14 of 15 checks passed
@pierregee pierregee deleted the pierregee/ocean-endpoint branch September 11, 2024 04:23
canonbrother pushed a commit that referenced this pull request Oct 10, 2024
@pierregee @canonbrother
chore(ui-ux): make ocean endpoint configurable via env (#1938)
37d16dc 
* chore(ui-ux): make ocean endpoint configurable via env

* change all ocean endpointss

* change all ocean endpointss

* fix naming

* fix naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fullstackninja864 fullstackninja864 fullstackninja864 approved these changes

@chloezxyy chloezxyy Awaiting requested review from chloezxyy

Assignees
No one assigned
Labels
area/layouts kind/chore Non feature change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierregee @chloezxyy @fullstackninja864