Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boundary condition bug? #21

Open
wang101 opened this issue Nov 30, 2021 · 0 comments
Open

Boundary condition bug? #21

wang101 opened this issue Nov 30, 2021 · 0 comments

Comments

@wang101
Copy link

wang101 commented Nov 30, 2021

https://github.com/histocartography/histocartography/blob/c8ecd8a74caf33057a2da291fa306500387d0ae0/histocartography/preprocessing/feature_extraction.py#L310

In line 310: if n_centroids < k: should be if n_centroids-k <2.
Reason: If not, it will incur bug in line 313, where kth should be smaller than n_centroids.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wang101