Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Detect when changing params in dataset_balanced_division_to_folds(reset_split=False) #185

Open
SagiPolaczek opened this issue Oct 2, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@SagiPolaczek
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
When calling dataset_balanced_division_to_folds(reset_split=False) we don't look at the parameters:

    if os.path.exists(output_split_filename) and not reset_split:
        return load_pickle(output_split_filename)
    else:
...

Meaning that if output_split_filename exists, the changes won't take place. Thus the user needs to change it manually or worse, be confused with the results.

Describe the solution you'd like
When necessary, auto-reset the split file.

Describe alternatives you've considered

  1. Save the parameters in the split file (or hash them) and read them each time, looking for a diff.
  2. Save the parameters (or hash them) in a different file.
  3. Manually inspect the parameters.

Additional context
:)

@SagiPolaczek SagiPolaczek added enhancement New feature or request good first issue Good for newcomers labels Oct 2, 2022
@SagiPolaczek
Copy link
Collaborator Author

Partially addressed in #312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant