We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuse-drug/fusedrug/data/tokenizer/modulartokenizer/modular_tokenizer.py
Line 1810 in 818cb8c
The function _get_max_mapped_special_id is just a copy of _get_max_mapped_id, so it doesn't do what it needs to. Instead, line https://github.com/BiomedSciAI/fuse-drug/blob/818cb8c3bb79065ce6539b9523cb6a1e594091cf/fusedrug/data/tokenizer/modulartokenizer/modular_tokenizer.py#L1389C13-L1389C56 implements a similar concept with max(special_vocab.values()).
Suggestion: Replace line 1389 with a call to _get_max_mapped_special_id and use max(special_vocab.values()) to implement _get_max_mapped_special_id.
The text was updated successfully, but these errors were encountered:
floccinauc
No branches or pull requests
fuse-drug/fusedrug/data/tokenizer/modulartokenizer/modular_tokenizer.py
Line 1810 in 818cb8c
The function _get_max_mapped_special_id is just a copy of _get_max_mapped_id, so it doesn't do what it needs to. Instead, line https://github.com/BiomedSciAI/fuse-drug/blob/818cb8c3bb79065ce6539b9523cb6a1e594091cf/fusedrug/data/tokenizer/modulartokenizer/modular_tokenizer.py#L1389C13-L1389C56 implements a similar concept with max(special_vocab.values()).
Suggestion: Replace line 1389 with a call to _get_max_mapped_special_id and use max(special_vocab.values()) to implement _get_max_mapped_special_id.
The text was updated successfully, but these errors were encountered: