-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disentangling assays and rowData #18
Comments
We could add another structure that will indicate what columns are to be converted to |
Can this issue be updated with an illustrative example and desired output? The verbal description is hard to follow and I do not know whether the example in the original issue is still relevant. |
Let's consider a typical output from SNP-based CNV callers stored as a
We group the calls by sample ID, resulting in a
Let's create some
Now when creating a
However, I would like to determine which mcols become assays (and which are annotation Desired output:
|
I don't want to support this. The implication is either that the software is 'smart' enough to fill rowData across ranges that are present in some but not all samples, or that the data is not actually ragged after all and all rows are present in all samples. It seems too arbitrary to know how to solve the first case, and the second case does not represent a ragged experiment. |
There is no need to fill rowData. Upon construction of a |
@lgeistlinger your desired specifies what the |
Some instances:
That is useful for approaches that resolve CNVs on the probe level for CNV-phenotype |
Some more thoughts: The full-blown Imho, having The two main aspects to this are:
Once you have found a number of summarized ranges to be particularly interesting As an example, we had doubt about a particular CNV in this study: https://www.nature.com/articles/s41598-018-19782-4 Based on SNP data, the region was inferred to be completely deleted (0 copies). We thus went back to the individual CNV calls and resolved them on SNP level to Long story short, often enough you are having characteristics describing your |
Following up on previous comments (#17):
RaggedExperiment
nicely pretends to be aSummarizedExperiment
with regard toassays
,rowRanges
, andcolData
.However,
RaggedExperiment
does not seem to support a concept such asrowData
for annotation to itsrowRanges
.I wonder whether this can be modified.
When constructing a
RaggedExperiment
from aGRangesList
, would it be possible to distinguish mcols that become assays and mcols that are annotation?(Currently this turns even non-numeric mcols into assays)
General motivation for being able to annotate additional row information is as for a
SummarizedExperiment
- however, in my specific use case I'm working with CNV calls where I only want the copy number to become an assay, while I want to keep additional columns as annotation to each individual CNV call (such as probe identifiers, quality measures, etc).The text was updated successfully, but these errors were encountered: