-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chevreul #3332
Comments
Hi @whtns Thanks for submitting your package. We are taking a quick The DESCRIPTION file for this package is:
|
All package dependencies must be on CRAN or Bioconductor. I assume |
Thank you for taking a look at these packages. I removed the annotables dependency in chevreul and added a vignette in chevreuldata. I'd greatly appreciate further review. |
adding an explicit reference to accompanying data package AdditionalPackage: https://github.com/whtns/chevreuldata |
Can't build unless issue is open and past pre-review stage, or issue is closed and 'TESTING' label is present. |
A few questions: Can default for saving or writing files be a tempdir() unless specified by a user? Insteading of defining Why is a It looks like you import httr::GET but is it utilized anywhere? |
Thank you for continuing to share feedback/shortcomings. I addressed the points you raised above in my last commit. Can default for saving or writing files be a tempdir() unless specified by a user? Insteading of defining ~/.cache/ which isn't necessarily a default for all operating systems can you use tools::R_user_dir(which="cache") or rappdirs::user_cache_dir which would grab an appropriate path for a given OS. Why is a chmod explicit set_permission_call necessary? It looks like you import httr::GET but is it utilized anywhere? |
When I try to run R CMD build I'm getting the following
It looks like you are hard linking to a file on your system that would not exist for a user. |
I'm sorry I can't identify the source of the errors listed above in my current branch. I incremented the package version. Can you confirm that the check and build is run against the devel branch? |
Yes it is
|
Ah, thank you very much. I had a mismatch between local and remote branches. The branch you are pulling is origin/sce in the above snippet. I've updated the local and remote branches and incremented version again. Can you try building again? Sorry for the trouble.
|
Same
In the vignette this seems to have to do with the plot_violin function. For what its worth it is also reproducible if I use devtools to load the package and just try to run that example as well
|
Ok, I think I've resolved this problem. The example dataset (in accompanying experimenthub package chevreuldata) includes a SingleCellLoomExperiment assay for use with the velociraptor package. Because the source loom file is inaccessible on any other system even unrelated functions break. Because I don't know best practices to share loom files in this manner I've removed that assay from the dataset and excluded those functions from vignettes and examples. |
You should not disable these examples and vignettes. If the data isn't loading, you should check out LoomExperiment where this class is defined and figure out the proper way. Exported functions need to be run/tested somewhere in the code base. |
Ok thanks, I recognize the submission requirement to have included functions documented with examples. I've removed any dependency on LoomExperiment or velociraptor from the package |
monocle3 does not appear to be on CRAN or Bioconductor. Bioconductor packages require all dependencies to be on CRAN or Bioconductor. You must remove the dependency from your package or request the monocle3 maintainers to officially submit the package. |
Thank you, we've removed all references to monocle3 and dropped the package dependency in DESCRIPTION |
Your package has been added to git.bioconductor.org to continue the IMPORTANT: Please read this documentation for setting Bioconductor utilized your github ssh-keys for git.bioconductor.org |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "skipped, ERROR". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: ed4e257b82d06540b3427c348ab8e17a8f453bc6 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "TIMEOUT". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Hi Marcel @LiNk-NY and Lori @lshep Three packages referenced in this issue have passed R CMD check without WARNING or ERROR:
Two other packages chevreuldata and chevreul have not passed. Could you let me know how to proceed? Thank you! |
Received a valid push on git.bioconductor.org; starting a build for commit id: c309c60287a91b5d66756c42fa5ff4ab2d3aaf8e |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "TIMEOUT". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: e438954375815b48d649ae7366e8c8d64ad41c2b |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "TIMEOUT". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: c9380612e642d3093b2421d3db4176abfd01a963 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "TIMEOUT". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Hi Kevin, @whtns |
Received a valid push on git.bioconductor.org; starting a build for commit id: 174869aac9381bf721b557dba70bcd104669318f |
Received a valid push on git.bioconductor.org; starting a build for commit id: 30edca0cf8365876601bb3af10686a30645d2939 |
Received a valid push on git.bioconductor.org; starting a build for commit id: 30ed939524c07a48894273ddc51f4e0edf83c81a |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. Congratulations! The package built without errors or warnings Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: 091ae893b30afc0f4ddec8b1f16a631443f04fad |
Received a valid push on git.bioconductor.org; starting a build for commit id: 81ef2d758cd6f3f77b479af6b444f6ce05bb59ef |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "WARNINGS". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Received a valid push on git.bioconductor.org; starting a build for commit id: d2c0954ac9ab2159c35235108eb2ed64b1db1cf3 |
Hi Marcel, @LiNk-NY. I updated package versions for the three separate packages that you suggested, but no longer meet minimum checktime requirements. Could this be due to changes in minimum R and Bioconductor versions? Do you have information on documentation to meet the 10 min threshold? |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
I understand that by submitting my package to Bioconductor,
the package source and all review commentary are visible to the
general public.
I have read the Bioconductor Package Submission
instructions. My package is consistent with the Bioconductor
Package Guidelines.
I understand Bioconductor Package Naming Policy and acknowledge
Bioconductor may retain use of package name.
I understand that a minimum requirement for package acceptance
is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
Passing these checks does not result in automatic acceptance. The
package will then undergo a formal review and recommendations for
acceptance regarding other Bioconductor standards will be addressed.
My package addresses statistical or bioinformatic issues related
to the analysis and comprehension of high throughput genomic data.
I am committed to the long-term maintenance of my package. This
includes monitoring the support site for issues that users may
have, subscribing to the bioc-devel mailing list to stay aware
of developments in the Bioconductor community, responding promptly
to requests for updates from the Core team in response to changes in
R or underlying software.
I am familiar with the Bioconductor code of conduct and
agree to abide by it.
I am familiar with the essential aspects of Bioconductor software
management, including:
months, for bug fixes.
(optionally via GitHub).
For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.
The text was updated successfully, but these errors were encountered: