Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use template functions for packing and unpacking instead of explicitly specyfying bit shifts #66

Open
DominikRafacz opened this issue Dec 17, 2020 · 0 comments
Open

Use template functions for packing and unpacking instead of explicitly specyfying bit shifts #66

DominikRafacz opened this issue Dec 17, 2020 · 0 comments
Labels
C++ adventures We thought we know how this language works... but sometimes... refactor Because we have too much free time
Projects
Constant refinement

Comments

@DominikRafacz
Copy link
Collaborator

In files inst/include/{unpack_common, unpack_string, pack}.h there are several versions of packing and unpacking which are hardcoded. They could be written using arithmetic of shifts wrapped in templates and expanded into those functions at compile time.
@DominikRafacz DominikRafacz added refactor Because we have too much free time C++ adventures We thought we know how this language works... but sometimes... labels Dec 17, 2020
@ErdaradunGaztea ErdaradunGaztea added this to To do in Constant refinement via automation Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++ adventures We thought we know how this language works... but sometimes... refactor Because we have too much free time
Projects
Constant refinement
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DominikRafacz