Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After constraint with second, fix inside #2588

Open
JoeyXitres opened this issue Sep 11, 2024 · 1 comment
Open

After constraint with second, fix inside #2588

JoeyXitres opened this issue Sep 11, 2024 · 1 comment

Comments

@JoeyXitres
Copy link

On line 55 in the AfterConstraint, it's compared with diffInHours. This should be in minutes, since Hours already is checked above.

$diff = (int) $schedule->timestamp_target->diffInHours(
now()->floorSeconds(),
absolute: true
);

This causes that now() diff in hours always is 0.

See line 60, delay min, but compared to diffInHours.

FIX
$diff = (int) $schedule->timestamp_target->diffInMinutes(
now()->floorSeconds(),
absolute: true
);

@drmmr763
Copy link

Thanks @JoeyXitres can confirm this is a bug I experienced as well. It seems a delay in minutes under 1 hour doesn't send. it does appear to send after being delayed 1 hour after the timestamp_target in my testing.

I think the fix proposed will work. I'm working on testing it now.

@binaryk please consider releasing bug fix, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants