Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Data): Note in profile page that Data represents Published Expeditions #595

Open
irag opened this issue Dec 26, 2017 · 4 comments
Open

Comments

@irag
Copy link

irag commented Dec 26, 2017

This is an enhancement. There is no bug.

My BOP user name is Ira Gershenhorn.

I took the following screenshot of the result of filtering Community>People by gershenhorn and then clicking on the image of the one returned person (me). Its obvious to me that Data represents Published Expeditions and Launched Expeditions represent expeditions NOT published. I realize that an expedition only becomes Data once its been published but it just strikes me that there's this syntactic change. I would prefer if Data was followed by (Published Expeditions) and Launched Expeditions were followed by (expeditions not published), because to my mind the expeditions listed under Data certainly were launched.

image

The file where this appears seems to be \modules\profiles\clients\views\view-user-content.client.view.html
in Lines 91, 105, 150, 162 (there are two cases of Data and Launched Expeditions).

There seems to be two different presentations based on whether one is the TeamLead or not.

If I could I would tag this as enhancement and help wanted.

@haflanagan
Copy link
Contributor

@irag This is a good point- I can see how it's not super clear what represents unpublished vs. published data. This is something I can code myself so I'll play around with this and double check with the team on their preferred language and I'll let you know what we come up with!

@irag
Copy link
Author

irag commented Jan 9, 2018

@haflanagan Yes. Definitely get agreement on what the language should be. I must have added the parenthetical part only because I wanted to limit my change. So maybe instead of Data it should be something like Published Expeditions used as Data and the second group might be Unpublished Expeditions. I'm not sure what 'launched' means. Either there's an expedition or there's not.

@haflanagan
Copy link
Contributor

@irag I checked with the team- we're going to go with "Launched (Unpublished)" and "Published." This was a great suggestion! (BTW, "launched" means an expedition was created, and you're right, technically every expedition on the platform has been launched, both published and unpublished expeditions.) Thanks so much for the feedback! I'll ping you when this change goes through (I'll probably get to it next week).

@irag
Copy link
Author

irag commented Jan 11, 2018

@haflanagan Fabulous! I know its so hard to get a decision like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants