Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG always using port 47808 #34

Open
2 tasks
Andrius1008 opened this issue Jun 22, 2021 · 1 comment
Open
2 tasks

BUG always using port 47808 #34

Andrius1008 opened this issue Jun 22, 2021 · 1 comment

Comments

@Andrius1008
Copy link

Node Version: v14.17.0

Node BACstack Version: 1.0.0

  • [X ] Bug Report
  • Feature Request
  • Question

Note: Make sure you have read the FAQs
before logging this issue.

Feature Request / Question

Current Behaviour (Bug Report)

const bacnetClient = new Bacnet({
port: 47809, // Use BAC1 as communication port
interface: '192.168.222.11', // Listen on a specific interface
broadcastAddress: '192.168.222.255', // Use the subnet broadcast address
apduTimeout: 60000 // Wait twice as long for response
});

currently discovering in port 47808,but in options there is 47809.

So the bug in transport.js Line 100.
this._server.send(buffer, 0, offset, port || DEFAULT_BACNET_PORT , address);

variable "port" is undefined.

Expected Behaviour (Bug Report)

Steps to reproduce Issue (Bug Report)

@Apollon77
Copy link
Collaborator

@Andrius1008 Could you prepare a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants