-
-
Notifications
You must be signed in to change notification settings - Fork 219
How to Contribute
Peter Strömberg edited this page Sep 4, 2019
·
36 revisions
Calva is mostly TypeScript, but some things are written in ClojureScript.
The CLJS code is compiled by shadow-cljs
into an npm library, that is then required from TypeScript.
Start by saying hello in #calva-dev at the Clojurians Slack. Then:
- Clone your fork of https://github.com/BetterThanTomorrow/calva
- Checkout the
development
branch. -
npm install
(This will install, amongst other things,shadow-cljs
) - Open the project root directory in VS Code. (You are using VS Code and Calva, right?)
The dev process is like so:
- Run the build task Watch TS.
- Wait for it to compile the TypeScript code and start watching. (Only takes a second).
- Run the build task Watch Webpack.
- Wait for it build its stuff and start watching. (This also only takes a second).
- (Optional, if you want to play with the cljs part of Calva) Jack in Calva to Calva itself.
- Choose to connect to the
:calva-lib
cljs REPL. - Wait for it to build and run the tests. (You'll see this happening in the Terminal spawned to run the Jack-in task.)
- Choose to connect to the
- Start the extension in debug mode (the Extension Host):
F5
. (This is the app with a cljs REPL server your Calva will connect to.) - Hack away. The watch task will rebuild the extension really quickly.
- You'll find the output from both build task in their respective vscode Terminal view, and for the cljs part in its Jack-in terminal.
- NB: There are no automated tests for the TS code, mainly because I don't know how to do it. Please consider setting that up to collect gold stars in heaven (as we say in Sweden).
- Restart the extension host when you have new TS code to test (CLJS code will hot-reload, just as you are used to).
- Make sure all tests pass. Please add some basic unit tests for any functionality in the ClojureScript code that you add or change.
- Package a
vsix
file:-
Note: It is good practice to hack the version of Calva in
package.json
before packaging. On Windows it seems this is even necessary in order to install Calva from the extension marketplace. Don't commit this change. -
vsce package
(you might need tonpm install -g vsce
first.) - Install the vsix in your VS Code (from the Extensions pane) and do some testing that the production build works.
-
Note: It is good practice to hack the version of Calva in
- Make sure you are directing the pull request at the
development
branch. - Mention any issues you are addressing or fixing. (Use the fixes/closes syntax, if applicable.)
When you have issued your Pull Request it is best to ping us about it to catch my attention. The #calva-dev channel of the Clojurians Slack is a good place for this ping, mention @pez
and @ksthen
even.