Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Mount on Hover #259

Open
4 tasks
TylerR909 opened this issue Sep 4, 2023 · 1 comment
Open
4 tasks

Preview Mount on Hover #259

TylerR909 opened this issue Sep 4, 2023 · 1 comment
Labels

Comments

@TylerR909
Copy link
Contributor

TylerR909 commented Sep 4, 2023

Proposed functionality

I'm just pre-documenting a feature I'd like to add eventually.

We can create a <PlayerModel /> frame and anchor it to the Settings UI, hidden. When a user mouses over a Checkbox to select a mount, we can call CharacterModelBase:SetCreature(creatureID) and Show the frame so users can preview the mount they're moused over.

Requirements

  • PlayerModel (or DressUpModel?)
  • Add a setting to turn this on or off (default: on)
  • Disable for non-Mainline for now
    • If we can get CreatureID in non-Mainline and store it in the Mount Table/DB we could probably pull this off
@TylerR909 TylerR909 added the type: feature Feature label Sep 4, 2023
@TylerR909
Copy link
Contributor Author

Just wanted to share some progress I made on this today. Couple bugs still, plus it only shows in the actual Settings UI (/br options, but not /br mounts). Not sure how close I am to any Wrath support.

But I think all the research is done, just need to do a ton of cleanup and make some final decisions about how I actually want to implement this thing.

cropped.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant