Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code complexity by piggybacking the "welcome" check based on whether or not the "new contributor" indicator is visible #155

Open
gparyani opened this issue Sep 6, 2018 · 1 comment

Comments

@gparyani
Copy link
Contributor

gparyani commented Sep 6, 2018

Currently, the script bases whether or not to put in a welcome message in an automatic comment on its own criteria.

I think that the code's complexity can be reduced by not using its own criteria, but instead simply checking to see if the "new contributor" indicator is visible on that specific post. I usually manually type in the welcome message myself if the indicator is present, but the script didn't add it.

@Benjol
Copy link
Owner

Benjol commented Feb 21, 2019

Good idea. Don't have time myself, but if someone wants to have a look, I'll pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants