Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iFrame Title for Accessibility #1

Open
TwisterMc opened this issue Dec 28, 2018 · 4 comments
Open

iFrame Title for Accessibility #1

TwisterMc opened this issue Dec 28, 2018 · 4 comments
Labels
enhancement help wanted

Comments

@TwisterMc
Copy link
Collaborator

For accessibility, iFrames should have titles. https://www.w3.org/TR/WCAG20-TECHS/H64.html

The user should be able to pass in a title with a generic title as a fallback.
@richaber
Copy link

@TwisterMc what would be a preferable "generic title as a fallback?"

@richaber
Copy link

We could use something like "Embedded PDF document" or "Embedded PDF viewer," if content author does not supply a title attribute, I'm just not sure what the preference would be.

@richaber
Copy link

@BenjaminLawson, @TwisterMc I'm going with 'Embedded PDF Document' as generic fallback for now, we can change it later if there is a desire to do so.

richaber added a commit to richaber/PDF.js-Viewer-Shortcode that referenced this issue Jul 29, 2019
@richaber
Add 'title' shortcode attribute to use on iframe for accessibility
a3be6f1 
Default to 'Embedded PDF Document' if content author does not supply a custom title attribute BenjaminLawson#1
@TwisterMc
Copy link
Collaborator Author

I like "Embedded PDF Document" fas the fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TwisterMc @BenjaminLawson @richaber