Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature description whitespace does not match Cucumber #209

Open
ciaranmcnulty opened this issue Feb 4, 2021 · 3 comments
Open

Feature description whitespace does not match Cucumber #209

ciaranmcnulty opened this issue Feb 4, 2021 · 3 comments

Comments

@ciaranmcnulty
Copy link
Contributor

We just seem to trim it slightly differently

Removing this line will add a failing test
https://github.com/Behat/Gherkin/blob/master/tests/Behat/Gherkin/Cucumber/CompatibilityTest.php#L39

@ciaranmcnulty
Copy link
Contributor Author

Would fixing this be a BC break? We can make a new method that returns the description with the same whitespace as cucumber but that seems over the top. Do people depend on this for something or do they blindly trim it?

@ciaranmcnulty
Copy link
Contributor Author

I'm almost tempted to WONTFIX this. Our version's better :)

@stof
Copy link
Member

stof commented Mar 9, 2021

I suggest discussing that with cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants