-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports cogbars from TG #11120
Open
Tsar-Salat
wants to merge
12
commits into
BeeStation:master
Choose a base branch
from
Tsar-Salat:cpr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ports cogbars from TG #11120
+376
−224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coggers!!! |
Rukofamicom
reviewed
Jul 13, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Planning to TM this later today. |
Bugs found during TM:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
"Cog Progressbars" are basically a notification that someone is doing a noticeable do_after, that other players are able to see.
Examples being(nonexhaustive):
Examples that, explicitly, others CANNOT see:
Ports:
Why It's Good For The Game
There is currently ZERO actual visual feedback that someone is preforming a do_after progressbar, even when it would make sense that they are. No, a
to_chat
does not count.This should provide a simple way to display to others that someone is interacting with something, with an easy way to blacklist stuff that shouldn't be as obvious
Testing Photographs and Procedure
Screenshots&Videos
Terribly edited, but it shows a few uses
iPuhoTqvbc.1.mp4
Changelog
🆑 rkz, jlsnow301, Jacquerel, Mothblocks
add: adds cogbars, a way for players to see others preforming actions
refactor: refactored CPR. You no longer have to click the patient for every pump. The action will repeat, slowly at first until gaining enough speed when your character starts getting in-tune with the Beegee's song.
refactor: refactored the way progressbars display on very large mobs, now they will be centre'd like expected
refactor: do_afters and numerous timed_action_flags
fix: npcs do not make progressbars, saves processing
/:cl: