Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bounty] Get our bodyparts/limbs/organs up to date with TG limbs. #7213

Open
PowerfulBacon opened this issue Jul 6, 2022 · 8 comments
Open
Labels
Bounty Strategic Milestone A long-term strategic development. PRs completed for issues with this tag will be high-priority. Triaged Issues that are exempt from the stale action

Comments

@PowerfulBacon
Copy link
Member

Summary

Kapu updated the limbs with some newer code, however this introduced a large number of bugs that require fixing.
This was going to be a simple bounty to fix the hair bug, however our code is so outdated from TG that it should just be fully updated to get all of the improvements they have done.

This bounty is for $100

Tasks

  • Update the limbs to be completely up to date with TG's limbs.
  • Remove any unnecessary TG code
  • Add any Bee specific code that isn't on TG
  • Test the PR with beecode (Make sure stuff like magic mirror works and people aren't bald anymore)
  • Handle any reviews required

Potentially Relevant PRs

There may be more that I missed, but this is everything that I could find. Some stuff may be TG specific

tgstation/tgstation#65523 (Major)
tgstation/tgstation#67017 (Major)
tgstation/tgstation#65887
tgstation/tgstation#65923
tgstation/tgstation#66065
tgstation/tgstation#66704
tgstation/tgstation#65904

tgstation/tgstation#66607
tgstation/tgstation#67436
tgstation/tgstation#67104

I think these ones should be, but they might contain only TG specific content:
tgstation/tgstation#67450
tgstation/tgstation#67532
tgstation/tgstation#68094
tgstation/tgstation#66103 (Not sure if we removed this too)
tgstation/tgstation#66112

tgstation/tgstation#68045

@PowerfulBacon PowerfulBacon added Triaged Issues that are exempt from the stale action Bounty labels Jul 6, 2022
@PowerfulBacon PowerfulBacon pinned this issue Jul 6, 2022
@Dejaku51
Copy link
Contributor

Dejaku51 commented Jul 6, 2022

can do this
sorry, nevermind can't do this. i forgot i have many PRs to do already

@Archanial
Copy link
Member

I can do that

@Archanial Archanial self-assigned this Jul 9, 2022
@Mat05usz
Copy link
Contributor

I have a question, what does kapulimbs give to a player and why are we spending 100$ on fixing it?

@Iamgoofball
Copy link
Contributor

Iamgoofball commented Aug 15, 2022

I have a question, what does kapulimbs give to a player and why are we spending 100$ on fixing it?

you don't get a say, sorry

@PowerfulBacon
Copy link
Member Author

I have a question, what does kapulimbs give to a player and why are we spending 100$ on fixing it?

This is a very large amount of work to complete, $100 isn't a lot considering normal developer pay but its hopefully an incentive for anyone consider doing it to prioritise working on this (SS13 in general doesn't bring a lot of income in, so paying decent rates is challenging, plus we wouldn't really want to get people coding strictly for the money who won't maintain things in the future).

@PowerfulBacon
Copy link
Member Author

@Archanial Are you still working on this?

@PowerfulBacon
Copy link
Member Author

Judging by its been over a year, I take it this is no longer being actively worked on.

@itsmeow
Copy link
Member

itsmeow commented Jun 22, 2023

I did partially fix one of the bugs here #8926

@PowerfulBacon PowerfulBacon added the Strategic Milestone A long-term strategic development. PRs completed for issues with this tag will be high-priority. label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty Strategic Milestone A long-term strategic development. PRs completed for issues with this tag will be high-priority. Triaged Issues that are exempt from the stale action
Projects
None yet
Development

No branches or pull requests

6 participants