Lobby screen people count towards Vote to leave

[Shiraizawa]

Issue reported from Round ID: irrelevant

Reporting client version: 514.1589

People who are simply connected but not in the round in any way, either Observing or actually playing shouldnt be counted towards Vote to leave count as they might as well be asleep for 10 hours with their PC running.

The following pull requests are currently test merged:
#9124: 'Enable serverside 515.1614' by Crossedfall at commit 1b8f225789
#10897: '[PORT] Follows up TG's atom_hud system' by EvilDragonfiend at commit 51f8edef4f
#10741: '[PORT] Removes overlay queuing, saves 6/7 seconds of initialize. Lightly modifies stat tracking macros (+some sprite error fix)' by EvilDragonfiend at commit 238d0f2194

[Tsar-Salat]

#11618

@Rukofamicom Intended or no?

The PR states it intended to give dead people the ability to vote but does this include newplayer mobs?

[Shiraizawa]

Its not the ability that is the issue, but that they are counted towards the necessary votes required for the shuttle to be called.

For example: 5 players are connected, 3 of which are on the lobby screen during the earlier times of the round the game will require all 5 connected players to vote, even though only 2 of those are actually in the game. This would be impossible to go through if out of the 5 players 2 left their game running for the past however many rounds and are AFK

[Rukofamicom]

strictly speaking, yes it is intended to include all online players.
It doesn't account for people who are loitering in the lobby without either joining or closing the game though.

Excluding AFK players would probably be a good idea in general.