-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSS Grid Layout Standard snippets #19
Comments
@BeastCode these type of snippets feel add-on. Perhaps they are a separate package, or use a different prefix? I guess the bottom line is what does the OP want? Examples? Css grid is dynamic and creating a useful one snip fits all is going to be quite hard. My suggestion is, while we are refactoring the snippets for Angular 5, we place examples (if that's what the OP intended) in a new prefix, 'example--'. Given this syntax, the OP would find his grid example with 'example-css-grid-layout' Thoughts? |
Downside to this is you don't have example snippets directly accessible from the real snips. ( Like for ng-pipe, ng-pipe-example). But, I think it actually might clean up the intellisense and provide a nice separation. Users typically know they are looking for the example when they need it. It's not something they decide when navigating the snippet intellisense. Following this idea through, the pipe example snip would be renamed to: example-ng-pipe |
How should we group examples? |
Doing So Im taking myself back, and I think we should do
|
No I like what you did there. I think doing |
I went trough the same thoughts when I created the first example snippet. But I do see a point grouping all angular examples ng-example- but at this point there's not many examples/// |
BeastCode,
Still missing ng-cong? me too!
Now that css grid layout has been adopted by Mozilla and Chrome, would be nice to have some snips.
-MB
The text was updated successfully, but these errors were encountered: