Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove References of Old Transit Skim Files #78

Open
AshishKuls opened this issue Nov 6, 2024 · 3 comments
Open

Remove References of Old Transit Skim Files #78

AshishKuls opened this issue Nov 6, 2024 · 3 comments
Labels

Comments

@AshishKuls
Copy link
Collaborator

Issue:
The transit skimming process in tm2py generates skim files with the naming convention as trnskmAM_KNR_TRN_WLK.omx. However, there is a second set of transit skim files, named transit_skims_period.omx, which are stored in the transit skim folder. These files are no longer produced but are still used by certain UECs in CT-RAMP. They are being carried around in all the latest model runs to get through this issue.

Details:
The WalkTransitWalkSkims and WalkTransitDriveSkims UECs in CT-RAMP uses the transit_skims_{period}.omx files. These UECs are initialized here and here in the code but appears that these UEC objects may no longer be necessary.

Fix:
Attempts to delete the transit_skims_{period}.omx files have shown that the model crashes without those files in place. To resolve this, Java code changes are required. Specifically:

  • If the UECs are not needed downstream, we should avoid initializing the corresponding UEC classes.
  • If the UECs are necessary, the code should be updated to use the correct set of transit skim file.

cc @DavidOry

@AshishKuls AshishKuls added the bug label Nov 6, 2024
@AshishKuls
Copy link
Collaborator Author

@DavidOry we should add this to technical debt as well.

@DavidOry
Copy link
Collaborator

DavidOry commented Nov 6, 2024

@DavidOry we should add this to technical debt as well.

Added. How many hours to fix?

@DavidOry DavidOry moved this to Todo in tm2py Technical Debt Nov 6, 2024
@AshishKuls
Copy link
Collaborator Author

@DavidOry we should add this to technical debt as well.

Added. How many hours to fix?

May be 8 hours. Haven't looked too closely on needed fix but I assume it should be simple and straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants