Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: GDAL import results in GH Actions Failing #93

Open
3 of 6 tasks
e-lo opened this issue Oct 31, 2022 · 0 comments · May be fixed by #94
Open
3 of 6 tasks

🐛 Bug: GDAL import results in GH Actions Failing #93

e-lo opened this issue Oct 31, 2022 · 0 comments · May be fixed by #94
Assignees
Labels
bug Something isn't working

Comments

@e-lo
Copy link
Collaborator

e-lo commented Oct 31, 2022

Describe the bug

gdal isn't installed if Emme isn't (and shouldn't be...its picky)

Progress:

  • Sufficient information provided
  • Cause identified/found
  • Test developed/identified
  • Approach determined
  • Test passes

To Reproduce

Run GH Actions

Failing tests

  • All

Triggering line of code

conftest.py

# why import gdal first: https://github.com/BayAreaMetro/tm2py/blob/7a563f0c5cea2125f28bfaedc50205e70c532094/README.md?plain=1#L57
import gdal

Thoughts on resolution

Import gdal in the inro_context() fixture before trying the inro import

import gdal
import inro.emme.database.emmebank

!!! note that this will cause it to use the mock if GDAL isn't installed either...which I think is ok.

@e-lo e-lo added the bug Something isn't working label Oct 31, 2022
@e-lo e-lo self-assigned this Oct 31, 2022
@e-lo e-lo linked a pull request Oct 31, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant