Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow separate square feet adjusters to be applied independently #348

Open
akselx opened this issue Dec 6, 2023 · 2 comments
Open

Allow separate square feet adjusters to be applied independently #348

akselx opened this issue Dec 6, 2023 · 2 comments

Comments

@akselx
Copy link

akselx commented Dec 6, 2023

It is possible that the run_setup.yaml file contains both run_telecommute_strategy and sqft_per_job_adjusters flags set as True. However, the code is currently set up such that base sqft adjusters (sqft_per_job_adjusters) are currently only applied if the flag run_telecommute_strategy in run_setup.yaml is set to False:

if run_setup["run_telecommute_strategy"] and year != base_year:

Otherwise the following elif statement is not evaluated - ideally these could be multiplicative - with a base adjustment, and then the strategy adjustment - though it depends on whether the telecommute adjustments are all inclusive - bundling in the base adjustments on the data side.

elif run_setup["sqft_per_job_adjusters"]:

@akselx
Copy link
Author

akselx commented Dec 6, 2023

@theocharides let me know if you think this is a general issue or just one related to my use case for leveraging sqft_per_job_adjusters for the exogenous adjustments.

@theocharides
Copy link

Hi @akselx - I think I need more code comments here to start, since it's not very straightforward. Also when I last looked at this I thought I saw a typo where the code comments for these lines are swapped.

The idea was that either telecommute rates get applied to future years, or the default rate gets applied, but in any case you can see it in the inputs based on what's turned on in run_setup.yaml without doing multiplication. But I see how that means you can't apply both at the same time without embedding the defaults in the future years.

@akselx akselx changed the title Allow separate square feet adjusters to be applied indepependently Allow separate square feet adjusters to be applied independently Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants