Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys checked for in baus.py need to be in run_setup.yaml #340

Open
akselx opened this issue Nov 6, 2023 · 1 comment
Open

Keys checked for in baus.py need to be in run_setup.yaml #340

akselx opened this issue Nov 6, 2023 · 1 comment

Comments

@akselx
Copy link

akselx commented Nov 6, 2023

baus.py currently checks for booleans for a number of steps. These will fail if the key is not defined in the run_setup.yaml file.

It may be cleaner to have the run_setup.yaml file be more minimal, with only relevant keys defined - and conversely in baus.py do a safe dict.get() check, with a False default.

This essentially means more default assumptions are moved to baus.py which may (or may not) be desirable.

Flagging this because errors are raised - the fix is either behavioral - enforce that any key mentioned in baus.py is defined in run_setup.yaml - or else, technical, using safe key getting in baus.py with appropriate defaults.

if run_setup["run_visualizer"]:

@lmz
Copy link
Member

lmz commented Dec 6, 2023

Related: #345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants