Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: BartoszCichecki/LenovoLegionToolkit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.10.0
Choose a base ref
...
head repository: BartoszCichecki/LenovoLegionToolkit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Loading
Showing 761 changed files with 68,075 additions and 13,383 deletions.
15 changes: 8 additions & 7 deletions .github/ISSUE_TEMPLATE/1_feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
name: Feature Request
description: Suggest an idea for this project
title: "[FEAT]: "
labels: ["feature"]
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this feature request. Please provide as much information as possible.
> [!IMPORTANT]
> Before you start, read [the rules](https://github.com/BartoszCichecki/LenovoLegionToolkit/blob/master/CONTRIBUTING.md) for contributing.
- type: input
id: version
attributes:
label: Version
description: Which Lenovo Legion Toolkit version do you use?
placeholder: e.g. 2.5.1
placeholder: e.g. 2.14.0
validations:
required: true
- type: input
@@ -36,23 +37,23 @@ body:
attributes:
label: Is your feature request related to a problem?
description: A clear and concise description of what the problem is.
placeholder: Type here...
placeholder: A clear and concise description of what the problem is.
validations:
required: true
- type: textarea
id: solution
attributes:
label: How would you like the problem to be solved?
description: A clear and concise description of what you would like to happen.
placeholder: Type here...
placeholder: A clear and concise description of what you would like to happen.
validations:
required: true
- type: textarea
id: alternatives
attributes:
label: What alternatives have you considered?
description: A clear and concise description of any alternative solutions or features you've considered.
placeholder: Type here...
description: A clear and concise description of any alternative solutions or features you have considered.
placeholder: A clear and concise description of any alternative solutions or features you have considered.
validations:
required: true
- type: textarea
44 changes: 18 additions & 26 deletions .github/ISSUE_TEMPLATE/2_bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
name: Bug Report
description: Something isn't working correctly
title: "[BUG]: "
labels: ["bug"]
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report. The more information you provide, the easier it will be for me to fix it!
> [!IMPORTANT]
> Before you start, read [the rules](https://github.com/BartoszCichecki/LenovoLegionToolkit/blob/master/CONTRIBUTING.md) for contributing.
- type: input
id: version
attributes:
label: Version
description: Which Lenovo Legion Toolkit version do you use?
placeholder: e.g. 2.5.1
placeholder: e.g. 2.14.0
validations:
required: true
- type: input
@@ -39,19 +40,27 @@ body:
placeholder: e.g. GKCN57WW
validations:
required: true
- type: textarea
id: troubleshoot
attributes:
label: What is wrong?
description: Provide detailed description of what is wrong or does not work as expected.
placeholder: Provide detailed description of what is wrong or does not work as expected.
validations:
required: true
- type: textarea
id: description
attributes:
label: What's wrong?
description: Provide description of what is wrong.
placeholder: Type here...
label: What did you try already?
description: Provide detailed description of how did you troubleshoot the issue and what have you tried already.
placeholder: Provide detailed description of how did you troubleshoot the issue and what have you tried already.
validations:
required: true
- type: textarea
id: reproduce
attributes:
label: How to reproduce the bug?
description: Describe how to reproduce the behavior. Try to be as specific as possible.
description: Describe how to reproduce the behavior. Be as specific as possible and provide as many details as possible.
placeholder: |
1. Go to '...'
2. Click on '....'
@@ -64,34 +73,17 @@ body:
attributes:
label: What is the behavior that you expected?
description: Describe what did you expect would happen.
placeholder: Type here...
placeholder: Describe what did you expect would happen.
validations:
required: true
- type: textarea
id: logs
attributes:
label: Logs
placeholder: Please drag and drop log files here. You can check README for instructions on how to collect logs.
description: Please drag and drop log files here. You can check README for instructions on how to collect logs.
validations:
required: true
- type: checkboxes
id: vantage-fn-keys
attributes:
label: Do you have Lenovo software installed?
description: Check all that you have installed on your system
options:
- label: Lenovo Vantage is installed
- label: Lenovo Hotkeys is installed
- label: None of the above
- type: checkboxes
id: vantage-fn-keys-disabled
attributes:
label: Did you disable any Lenovo software using Lenovo Legion Toolkit?
description: Check all that you have disabled with Lenovo Legion Toolkit
options:
- label: Lenovo Vantage
- label: Lenovo Hotkeys
- label: I disabled some things on my own (please write below what you did)
- type: textarea
id: additional
attributes:
13 changes: 4 additions & 9 deletions .github/ISSUE_TEMPLATE/3_compatibility_request.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,19 @@
name: Compatibility Request
description: Request support for a device that is not supported
title: "[COMPATIBILITY]: "
labels: ["compatibility"]
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this compatibility request. Please provide as much information as possible.
**IMPORTANT:**
**Support is limited only to laptops from Lenovo Legion series. Other devices will not be supported. Issues related to other devices will not be looked at!**
> [!IMPORTANT]
> Before you start, read [the rules](https://github.com/BartoszCichecki/LenovoLegionToolkit/blob/master/CONTRIBUTING.md) for contributing.
- type: input
id: version
attributes:
label: Version
description: Which Lenovo Legion Toolkit version do you use?
placeholder: e.g. 2.5.1
placeholder: e.g. 2.14.0
validations:
required: true
- type: input
4 changes: 4 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
blank_issues_enabled: false
contact_links:
- name: General questions
url: https://github.com/BartoszCichecki/LenovoLegionToolkit/discussions/new?category=q-a
about: Please ask questions here.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -13,17 +13,17 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup .NET
uses: actions/setup-dotnet@v3
with:
dotnet-version: 6.0.x
dotnet-version: 8.0.x
- name: Restore
run: dotnet restore
- name: Build
run: .\make.bat
- name: Upload artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: installer
path: build_installer\LenovoLegionToolkitSetup.exe
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -12,11 +12,11 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup .NET
uses: actions/setup-dotnet@v3
with:
dotnet-version: 6.0.x
dotnet-version: 8.0.x
- name: Restore
run: dotnet restore
- name: Build
@@ -28,7 +28,7 @@ jobs:
files: build_installer/LenovoLegionToolkitSetup.exe
fail_on_unmatched_files: true
- name: Upload artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: installer
path: build_installer/LenovoLegionToolkitSetup.exe
64 changes: 56 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,61 @@
## Welcome to Lenvo Legion Toolkit contributing guide
## Welcome to Lenvo Legion Toolkit contributing guide!

Thanks for investing your time in contributing to this project!
### Other language versions of this contributing guide:
* [简体中文版开发者指南](CONTRIBUTING_zh-hans.md)
* [日本語版の貢献ガイド](CONTRIBUTING_ja-JP.md)

Giving the growing popularity of LLT, here are a few rules to follow to ensure that your contribution goes smoothly.
Thanks for investing your time in contributing to this project! Giving the growing popularity of LLT, here are a few rules to follow to ensure that your contribution goes smoothly.

1. All pull requests need an accompanying issue.
2. All issues, pull requests, commit messages must be written in English.
3. Translation contributions are done using [Crowdin](https://crowdin.com/project/llt), so please request access to the project there if you want to contribute.
4. Pull Requests with translations **will not** be accepted.
5. If you plan working on a feature, please start an issue or a discusion first, to make sure that your idea is aligned with the project goals.
<br/>

_Due to large number of issues created, those that do not meet the criteria will be deleted without warning. Repeating offenders will be banned._

<br/>

**1. Before reporting an issue make yourself familiar with the README**

[README](https://github.com/BartoszCichecki/LenovoLegionToolkit/blob/master/README.md) is regularly updated to include answers to frequently asked questions as well as information about most common issues. Take your time to go through what is there before creating an issue or starting a discussion.

**2. Check already reported issues**

Go through [issues](https://github.com/BartoszCichecki/LenovoLegionToolkit/issues?q=is%3Aissue) that were already reported, as well as [discussions](https://github.com/BartoszCichecki/LenovoLegionToolkit/discussions?discussions_q=). Do not create duplicate issues or discussions. Even if the issue is marked as closed, you can still leave a comment there.

**3. Use English**

This makes it easier for everyone to follow the conversation.

**4. Respect scope of the project**

This is not meant to be a do-it-all type of application. The vision for the project is clear: provide a replacement of Vantage for Legion laptops. Do not request support for other types/models/etc devices.

**5. Verify your problem before creating an issue**

Make sure that a bug is really a bug in LLT - this isn't a free system troubleshooting forum. If you use modified version of Windows or your Windows is acting funny, that's on you.

**6. Describe your problem as best as you can**

Providing good description is key. Fill out all the fields of the form when creating an issue, including logs. The better the description, the higher the chance that we will understand each other correctly.

**7. Give a good title to issues and discussions**

It is a lot easier to browse the list and follow issues and discussions. "Error when using LLT" is not a good title.

**8. Stay on topic**

Do not leave unnecessary comments or spam.

**9. One problem per issue**

Do not report many problems or request many features withing one issue. Make one issue or discussion per problem/topic/idea. This makes it easier to follow.

**10. Translations**

Translation contributions are done using [Crowdin](https://crowdin.com/project/llt), so please request access to the project there if you want to contribute.

**11. Pull requests**

Pull requests are welcome (of course). Unless you create a very simple and understandable PR, make an issue first and describe the problem you are solving. It doesn't make sense to spend time working on an idea that will be rejected, because it doesn't fit the project vision. Follow the code style and architecture of the project.

<br/>

Once again, thanks for investing your time in helping LLT get better!
61 changes: 61 additions & 0 deletions CONTRIBUTING_ja-JP.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
## Lenovo Legion Toolkit への貢献ガイドへようこそ!

### この貢献ガイドの他の言語バージョン:
* [英語版の貢献ガイド](CONTRIBUTING.md)
* [簡体字中国語版の貢献ガイド](CONTRIBUTING_zh-hans.md)

このプロジェクトに貢献するために時間を割いていただきありがとうございます! LLTの人気が高まっているため、貢献がスムーズに進むようにするために、いくつかのルールに従ってください。

<br/>

_作成された問題の数が多いため、基準を満たさないものは警告なしに削除されます。繰り返し違反する者は禁止されます。_

<br/>

**1. 問題を報告する前にREADMEをよく読んでください**

[README](https://github.com/BartoszCichecki/LenovoLegionToolkit/blob/master/README.md)は、よくある質問への回答や最も一般的な問題に関する情報を���むように定期的に更新されます。問題を作成する前に、そこにある内容を確認してください。

**2. 既に報告されている問題を確認してください**

既に報告されている[問題](https://github.com/BartoszCichecki/LenovoLegionToolkit/issues?q=is%3Aissue)[ディスカッション](https://github.com/BartoszCichecki/LenovoLegionToolkit/discussions?discussions_q=)を確認してください。重複する問題やディスカッションを作成しないでください。問題がクローズされていても、コメントを残すことができます。

**3. 英語を使用してください**

これにより、すべての人が会話を追跡しやすくなります。

**4. プロジェクトの範囲を尊重してください**

これは万能のアプリケーションを目指しているわけではありません。プロジェクトのビジョンは明確です:LegionノートパソコンのためのVantageの代替品を提供すること。他のタイプ/モデル/デバイスのサポートを要求しないでください。

**5. 問題を作成する前に問題を確認してください**

バグが本当にLLTのバグであることを確認してください - これは無料のシステムトラブルシューティングフォーラムではありません。Windowsの改造版を使用している場合や、Windowsが正常に動作していない場合、それはあなたの責任です。

**6. 問題をできるだけ詳しく説明してください**

良い説明を提供することが重要です。問題を作成する際には、フォームのすべてのフィールドを記入し、ログを含めてください。説明が良ければ良いほど、私たちが正しく理解する可能性が高くなります。

**7. 問題やディスカッションに良いタイトルを付けてください**

リストを閲覧し、問題やディスカッションを追跡するのがはるかに簡単です。「LLTを使用中にエラーが発生しました」は良いタイトルではありません。

**8. トピックに集中してください**

不要なコメントやスパムを残さないでください。

**9. 1つの問題につき1つの問題**

1つの問題で多くの問題を報告したり、多くの機能を要求したりしないでください。問題/トピック/アイデアごとに1つの問題やディスカッションを作成してください。これにより、追跡が容易になります。

**10. 翻訳**

翻訳の貢献は[Crowdin](https://crowdin.com/project/llt)を使用して行われるため、貢献したい場合はそこでプロジェクトへのアクセスをリクエストしてください。

**11. プルリクエスト**

プルリクエストは歓迎されます(もちろんです)。非常にシンプルで理解しやすいPRを作成しない限り、最初に問題を作成し、解決している問題を説明してください。プロジェクトのビジョンに合わないアイデアに時間を費やすのは意味がありません。プロジェクトのコードスタイルとアーキテクチャに従ってください。

<br/>

もう一度、LLTをより良くするために時間を割いていただきありがとうございます!
Loading