Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Adding helpText to a field after initial creation causes layout issues #188

Open
Aubron opened this issue Aug 20, 2018 · 1 comment
Open
Labels
bug fields Bugs or feature requests for the Field layout system

Comments

@Aubron
Copy link
Contributor

Aubron commented Aug 20, 2018

This is 'best I can tell', I'm not super well versed in CSS grid.

It appears that if you initialize some Field inside a Fields without helptext, it will not generate the row for helpText. This is 👍, for layout reasons. However, if you later add helpText (in for example, an error scenario) it creates a whole new column in which to place the helpText. See attached:

Before

After

Current Bad Workaround: Pass some whitespace into helpText to ensure the row is properly generated, if you later might need that row.

@a-type
Copy link
Contributor

a-type commented Aug 21, 2018

Huh, good call. The grid system may be a little inflexible. Honestly, it's a bit hacked anyway... it's been hard to come up with a good, stable solution for vertically-aligned multi-column field layouts.

@a-type a-type added fields Bugs or feature requests for the Field layout system bug labels Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fields Bugs or feature requests for the Field layout system
Projects
None yet
Development

No branches or pull requests

2 participants