New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revisit allreduce for moe.gate... #232

Open

todo bot opened this issue Sep 28, 2021 · 0 comments

Labels

todo bot commented Sep 28, 2021

bagua/bagua/torch_api/model_parallel/moe/experts.py

Lines 25 to 30 in 013a3c3

    
           # TODO: revisit allreduce for moe.gate... 
        
           for expert in self.deepspeed_experts: 
        
               # TODO: Create param groups to handle expert + data case (e.g. param.group = moe_group) 
        
               for name, param in expert.named_parameters(): 
        
                   param.allreduce = False

This issue was generated by todo based on a `TODO` comment in `013a3c3` when #208 was merged. cc @BaguaSys.

The text was updated successfully, but these errors were encountered:

todo bot added the todo 🗒️ label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment