Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cool DBML Visualizer (Please add PK and NOT NULL) #68

Open
herzadinata opened this issue Oct 28, 2024 · 5 comments
Open

Cool DBML Visualizer (Please add PK and NOT NULL) #68

herzadinata opened this issue Oct 28, 2024 · 5 comments

Comments

@herzadinata
Copy link

Great work!

Your VSCode DBML visualizer extension is actually more appealing visually than other extensions.
Also you added a bit of interactivity: when hovering a field, it highlights its foreign key in other tables. I really like that, that gives it life, unlike other extensions just plain soulless dead image.

But unfortunatly there are crucial features still missing, such as:

  • primary key
  • not null

Hopefully you will add those in the future.
Really looking forward to see those implemented.

Thank you, really! Really appreciated it!

@BOCOVO
Copy link
Owner

BOCOVO commented Oct 28, 2024

Hello @herzadinata !
I really appreciate your kind words. Thanks.

Can add more detail about the expected result ?

@herzadinata
Copy link
Author

herzadinata commented Oct 28, 2024

@BOCOVO

Screenshot 2024-10-28 at 15 57 02

Expectation (picture above as reference):

  • primary key: maybe you can simply bold the fields, or probably add "(PK)" text after the field name, just to give a hint it's a "primary key" field.
  • not null: maybe you can add the text (!) after the field type name, to give a hint it's a "not null" field.

Thank you!

@herzadinata herzadinata changed the title Cool DBML Visualizer Cool DBML Visualizer (Please add PK and NOT NULL) Oct 28, 2024
@herzadinata
Copy link
Author

@BOCOVO it seems like your extension can't have multiple/composite primary keys? If single primary key, it's already bolded. If multiple/composite primary keys, none is bolded.

Here is the screenshot from your extension:

Composite primary keys:
Screenshot 2024-10-28 at 16 49 37
Screenshot 2024-10-28 at 16 51 14

Single primary key:
Screenshot 2024-10-28 at 16 52 26
Screenshot 2024-10-28 at 16 52 49

@herzadinata
Copy link
Author

Another screenshot:

Multiple separate primary keys:
Screenshot 2024-10-28 at 16 54 19
Screenshot 2024-10-28 at 16 55 06
They're not bolded

@BOCOVO
Copy link
Owner

BOCOVO commented Oct 29, 2024

@BOCOVO it seems like your extension can't have multiple/composite primary keys? If single primary key, it's already bolded. If multiple/composite primary keys, none is bolded.

Here is the screenshot from your extension:

Composite primary keys: Screenshot 2024-10-28 at 16 49 37 Screenshot 2024-10-28 at 16 51 14

Single primary key: Screenshot 2024-10-28 at 16 52 26 Screenshot 2024-10-28 at 16 52 49

thank you for identifying this.
I know better where to look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants