Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread-Safety Issues #14

Open
carlbennett opened this issue Dec 1, 2020 · 3 comments
Open

Thread-Safety Issues #14

carlbennett opened this issue Dec 1, 2020 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@carlbennett
Copy link
Member

carlbennett commented Dec 1, 2020

This issue was created to track thread-safety issues in the early stages of the development of Atlas.

@carlbennett carlbennett changed the title Looping over the gameAds list isn't thread-safe. This may cause problems if a game is added or removed while this loop is processing. This safety issue is a systemic problem within Atlas however, and I understand if this is out of scope; I would just add a lock{} around it. Thread-Safety Issues Dec 1, 2020
@carlbennett carlbennett added the bug Something isn't working label Dec 1, 2020
@carlbennett
Copy link
Member Author

Looping over the gameAds list isn't thread-safe. This may cause problems if a game is added or removed while this loop is processing. This safety issue is a systemic problem within Atlas however, and I understand if this is out of scope; I would just add a lock{} around it.

Originally posted by @carlbennett in #13 (comment)

@x3haloed
Copy link

Maybe I can help out. Are you worried about adding locks? If not, I can go through and analyze the multithreaded stuff so it's all thread-safe with locks.

@carlbennett
Copy link
Member Author

@x3haloed If you want to fork the project and assist by creating a pull request with your work, it would be reviewed and likely welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants