Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a responsive-height-craft-visual component. #45

Closed
weotch opened this issue Apr 30, 2021 · 1 comment
Closed

Make a responsive-height-craft-visual component. #45

weotch opened this issue Apr 30, 2021 · 1 comment

Comments

@weotch
Copy link
Member

weotch commented Apr 30, 2021

The point would be for 100vw x 100vh images where srcset alone isn't going to cut it. Take the case of a square viewport and a 16:9 image. It's going to get scaled up to fit the viewport. The solve would be something like this, where we create a bunch of source elements. It would pretty much requires an image CDN to work.

This would probably consume responsive-craft-visual. I don't have a clear line of site on the API for this.
@weotch
Copy link
Member Author

weotch commented May 6, 2021

Moved to BKWLD/cloak-visual#1

@weotch weotch closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weotch