You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The EventParticipant model having a nullable hoursEarned field is old functionality leftover from when EventParticipant and EventRsvp were the same table. There really shouldn't be a case when their hours earned is None, at the very least it should only be 0. We need to change the following:
The EventParticipant model's hoursEarned field
Test data where hoursEarned is set to 0
Tests that test for hoursEarned to be None (at least one is in test_spreadsheet
Make sure there isn't any place in logic where we are setting their hoursEarned values
The text was updated successfully, but these errors were encountered:
@bledsoef HoursEarned is None if a participant volunteers in a 'no-hours-earning' event (e.g. empty bowls), and a number in an 'hours-earning-event (e.g. tutoring).
We don't think there's an issue. What do you think?
Low priority issue, leave for summer cohort
The
EventParticipant
model having a nullablehoursEarned
field is old functionality leftover from whenEventParticipant
andEventRsvp
were the same table. There really shouldn't be a case when their hours earned isNone
, at the very least it should only be 0. We need to change the following:EventParticipant
model'shoursEarned
fieldhoursEarned
is set to 0hoursEarned
to be None (at least one is in test_spreadsheethoursEarned
valuesThe text was updated successfully, but these errors were encountered: