New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden modal with the transition property will never close. #44

Open

DmitriiTurlychkin opened this issue Jan 24, 2019 · 1 comment

DmitriiTurlychkin commented Jan 24, 2019

Hi!
I faced an issue when we can't close modal window.
If we going to close a modal window which has the transition property, modal won't close.

Because removing will happen only on onTransitionEnd event
(https://github.com/BBVAEngineering/ember-modal-service/blob/master/addon/components/modal.js#L177)
But onTransitionEnd will never happen because the modal window is already hidden.

Contributor

adrigzr commented May 8, 2019

Hi, @DmitriiTurlychkin

If it is hidden, it should be closed. How do you have a modal already hidden but not closed?

litvishko mentioned this issue

feat: public method to close hidden modal window #57

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment