Skip to content

Commit d239b4c

Browse files
committed
Skipping failing E2E tests for macOS due to Keychain access required by the Kevault component
1 parent 1422d14 commit d239b4c

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

MSAL/test/integration/native_auth/end_to_end/mfa/MSALNativeAuthSignInWithMFAEndToEndTests.swift

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ import MSAL
2929
final class MSALNativeAuthSignInWithMFAEndToEndTests: MSALNativeAuthEndToEndPasswordTestCase {
3030

3131
func test_signInUsingPasswordWithMFASubmitWrongChallengeResendChallengeThen_completeSuccessfully() async throws {
32+
#if os(macOS)
33+
throw XCTSkip("Keychain access is not active on the macOS app and is used by Keyvault")
34+
#endif
3235
guard let username = retrieveUsernameForSignInUsernamePasswordAndMFA(),
3336
let password = await retrievePasswordForSignInUsername(),
3437
let awaitingMFAState = await signInUsernameAndPassword(username: username, password: password)
@@ -85,6 +88,9 @@ final class MSALNativeAuthSignInWithMFAEndToEndTests: MSALNativeAuthEndToEndPass
8588
}
8689

8790
func test_signInUsingPasswordWithMFAGetAuthMethods_thenCompleteSuccessfully() async throws {
91+
#if os(macOS)
92+
throw XCTSkip("Keychain access is not active on the macOS app and is used by Keyvault")
93+
#endif
8894
guard let username = retrieveUsernameForSignInUsernamePasswordAndMFA(),
8995
let password = await retrievePasswordForSignInUsername(),
9096
let awaitingMFAState = await signInUsernameAndPassword(username: username, password: password)
@@ -140,6 +146,9 @@ final class MSALNativeAuthSignInWithMFAEndToEndTests: MSALNativeAuthEndToEndPass
140146
}
141147

142148
func test_signInUsingPasswordWithMFANoDefaultAuthMethod_completeSuccessfully() async throws {
149+
#if os(macOS)
150+
throw XCTSkip("Keychain access is not active on the macOS app and is used by Keyvault")
151+
#endif
143152
guard let username = retrieveUsernameForSignInUsernamePasswordAndMFANoDefaultAuthMethod(),
144153
let password = await retrievePasswordForSignInUsername(),
145154
let awaitingMFAState = await signInUsernameAndPassword(username: username, password: password)

MSAL/test/integration/native_auth/end_to_end/sign_in/MSALNativeAuthSignInUserNameAndPasswordEndToEndTests.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,9 @@ final class MSALNativeAuthSignInUsernameAndPasswordEndToEndTests: MSALNativeAuth
6666

6767
// Hero Scenario 1.2.1. Sign in - Use email and password to get token
6868
func test_signInUsingPasswordWithKnownUsernameResultsInSuccess() async throws {
69+
#if os(macOS)
70+
throw XCTSkip("Keychain access is not active on the macOS app and is used by Keyvault")
71+
#endif
6972
guard let sut = initialisePublicClientApplication(), let username = retrieveUsernameForSignInUsernameAndPassword(), let password = await retrievePasswordForSignInUsername() else {
7073
XCTFail("Missing information")
7174
return

0 commit comments

Comments
 (0)