feat: logic app ftp and scm basic authentication enablement (#200)

* addition of functionality

* linting checks

---------

Co-authored-by: root <[email protected]>

Author: donovm4

README.md

@@ -133,15 +133,11 @@ Default: `true`
 
 ### <a name="input_app_service_active_slot"></a> [app\_service\_active\_slot](#input\_app\_service\_active\_slot)
 
-Description:
-  ```
-  Object that sets the active slot for the App Service.
+Description:   Object that sets the active slot for the App Service.
 
   `slot_key` - The key of the slot object to set as active.
   `overwrite_network_config` - Determines if the network configuration should be overwritten. Defaults to `true`.
 
-```
-
 Type:
 
 ```hcl
@@ -912,9 +908,7 @@ Default: `0`
 
 ### <a name="input_deployment_slots"></a> [deployment\_slots](#input\_deployment\_slots)
 
-Description:
-  ```
-  > NOTE: If you plan to use the attribute reference of an external Application Insights instance for `application_insights_connection_string` and `application_insights_key`, you will likely need to remove the sensitivity level. For example, using the `nonsensitive` function.
+Description:   > NOTE: If you plan to use the attribute reference of an external Application Insights instance for `application_insights_connection_string` and `application_insights_key`, you will likely need to remove the sensitivity level. For example, using the `nonsensitive` function.
 
   - `storage_shares_to_mount` - A map of storage shares to mount to the Function App deployment slot.
     - `name` - The name of the share.
@@ -923,7 +917,6 @@ Description:
     - `share_name` - The name of the share in the Storage Account.
     - `mount_path` - The path where the share will be mounted in the Function App.
     - `type` - The type of mount, defaults to "AzureFiles".
-```
 
 Type:
 
@@ -1691,6 +1684,14 @@ map(object({
 
 Default: `{}`
 
+### <a name="input_scm_publish_basic_authentication_enabled"></a> [scm\_publish\_basic\_authentication\_enabled](#input\_scm\_publish\_basic\_authentication\_enabled)
+
+Description: Should basic authentication be enabled for SCM publish?
+
+Type: `bool`
+
+Default: `true`
+
 ### <a name="input_site_config"></a> [site\_config](#input\_site\_config)
 
 Description:   An object that configures the Function App's `site_config` block.

main.logic_app.tf

@@ -1,21 +1,22 @@
 resource "azurerm_logic_app_standard" "this" {
   count = var.kind == "logicapp" ? 1 : 0
 
-  app_service_plan_id        = var.service_plan_resource_id
-  location                   = var.location
-  name                       = var.name
-  resource_group_name        = var.resource_group_name
-  storage_account_access_key = var.storage_account_access_key
-  storage_account_name       = var.storage_account_name
-  app_settings               = var.app_settings
-  bundle_version             = var.bundle_version
-  client_affinity_enabled    = var.client_affinity_enabled
-  client_certificate_mode    = var.client_certificate_mode
-  enabled                    = var.enabled
-  # ftp_publish_basic_authentication_enabled = var.ftp_publish_basic_authentication_enabled
-  https_only                 = var.https_only
-  public_network_access      = var.public_network_access_enabled == true ? "Enabled" : "Disabled"
-  storage_account_share_name = var.storage_account_share_name
+  app_service_plan_id                      = var.service_plan_resource_id
+  location                                 = var.location
+  name                                     = var.name
+  resource_group_name                      = var.resource_group_name
+  storage_account_access_key               = var.storage_account_access_key
+  storage_account_name                     = var.storage_account_name
+  app_settings                             = var.app_settings
+  bundle_version                           = var.bundle_version
+  client_affinity_enabled                  = var.client_affinity_enabled
+  client_certificate_mode                  = var.client_certificate_mode
+  enabled                                  = var.enabled
+  ftp_publish_basic_authentication_enabled = var.ftp_publish_basic_authentication_enabled
+  https_only                               = var.https_only
+  public_network_access                    = var.public_network_access_enabled == true ? "Enabled" : "Disabled"
+  scm_publish_basic_authentication_enabled = var.scm_publish_basic_authentication_enabled
+  storage_account_share_name               = var.storage_account_share_name
   # vnet_content_share_enabled = var.vnet_content_share_enabled
   tags                      = var.tags
   use_extension_bundle      = var.use_extension_bundle
@@ -39,7 +40,6 @@ resource "azurerm_logic_app_standard" "this" {
       identity_ids = identity.value.user_assigned_resource_ids
     }
   }
-  # scm_publish_basic_authentication_enabled = var.scm_publish_basic_authentication_enabled
   site_config {
     always_on                        = var.site_config.always_on
     app_scale_limit                  = var.site_config.app_scale_limit

variables.slots.tf

@@ -5,14 +5,10 @@ variable "app_service_active_slot" {
   })
   default     = null
   description = <<DESCRIPTION
-
-  ```
   Object that sets the active slot for the App Service.
 
   `slot_key` - The key of the slot object to set as active.
   `overwrite_network_config` - Determines if the network configuration should be overwritten. Defaults to `true`.
-
-  ```
   DESCRIPTION
 }
 
@@ -448,8 +444,6 @@ variable "deployment_slots" {
 
   }
   description = <<DESCRIPTION
-
-  ```
   > NOTE: If you plan to use the attribute reference of an external Application Insights instance for `application_insights_connection_string` and `application_insights_key`, you will likely need to remove the sensitivity level. For example, using the `nonsensitive` function.
 
   - `storage_shares_to_mount` - A map of storage shares to mount to the Function App deployment slot.
@@ -459,7 +453,6 @@ variable "deployment_slots" {
     - `share_name` - The name of the share in the Storage Account.
     - `mount_path` - The path where the share will be mounted in the Function App.
     - `type` - The type of mount, defaults to "AzureFiles".
-  ```
   DESCRIPTION
 }
 

variables.tf

@@ -1120,6 +1120,12 @@ DESCRIPTION
   nullable    = false
 }
 
+variable "scm_publish_basic_authentication_enabled" {
+  type        = bool
+  default     = true
+  description = "Should basic authentication be enabled for SCM publish?"
+}
+
 variable "site_config" {
   type = object({
     always_on             = optional(bool, true)