From 10eba4f54375b142df7d18ccd9fdc8b52ad4e864 Mon Sep 17 00:00:00 2001 From: asukumar22 <70966383+asukumar22@users.noreply.github.com> Date: Mon, 16 Sep 2024 21:08:45 -0700 Subject: [PATCH 1/4] Update network_appdelivery_checklist.en.json Added ARG query to A01.54 --- checklists/network_appdelivery_checklist.en.json | 1 + 1 file changed, 1 insertion(+) diff --git a/checklists/network_appdelivery_checklist.en.json b/checklists/network_appdelivery_checklist.en.json index fb8366a3d..65fa578ba 100644 --- a/checklists/network_appdelivery_checklist.en.json +++ b/checklists/network_appdelivery_checklist.en.json @@ -343,6 +343,7 @@ "id": "A01.54", "severity": "High", "link": "https://learn.microsoft.com/azure/application-gateway/ssl-overview" + "graph": "resources | where type == "microsoft.network/applicationgateways"| where properties['backendHttpSettingsCollection'][0]['properties']['port'] == "443" |distinct id,name, }, { "category": "Network Topology and Connectivity", From 280f34d98e7ec9434f98be7a4bd3807e160b82bb Mon Sep 17 00:00:00 2001 From: asukumar22 <70966383+asukumar22@users.noreply.github.com> Date: Tue, 17 Sep 2024 16:15:57 -0700 Subject: [PATCH 2/4] Update network_appdelivery_checklist.en.json Modified ARG query with Compliant tag and added comma to the last --- checklists/network_appdelivery_checklist.en.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/checklists/network_appdelivery_checklist.en.json b/checklists/network_appdelivery_checklist.en.json index 65fa578ba..43a96f941 100644 --- a/checklists/network_appdelivery_checklist.en.json +++ b/checklists/network_appdelivery_checklist.en.json @@ -342,8 +342,9 @@ "guid": "a66f0fd8-2ca4-422e-8df3-235148127ca2", "id": "A01.54", "severity": "High", + "graph": "resources | where type == "microsoft.network/applicationgateways"| extend compliant = (properties['backendHttpSettingsCollection'][0]['properties']['port'] == "443") |where properties['backendHttpSettingsCollection'][0]['properties']['port'] == "443" |distinct id,name,compliant", "link": "https://learn.microsoft.com/azure/application-gateway/ssl-overview" - "graph": "resources | where type == "microsoft.network/applicationgateways"| where properties['backendHttpSettingsCollection'][0]['properties']['port'] == "443" |distinct id,name, + }, { "category": "Network Topology and Connectivity", From eee1e438a84e3bbdfcf07946db623404c0ddf517 Mon Sep 17 00:00:00 2001 From: asukumar22 <70966383+asukumar22@users.noreply.github.com> Date: Mon, 23 Sep 2024 07:20:32 -0700 Subject: [PATCH 3/4] Update network_appdelivery_checklist.en.json --- checklists/network_appdelivery_checklist.en.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checklists/network_appdelivery_checklist.en.json b/checklists/network_appdelivery_checklist.en.json index 43a96f941..13fbb8daa 100644 --- a/checklists/network_appdelivery_checklist.en.json +++ b/checklists/network_appdelivery_checklist.en.json @@ -342,7 +342,7 @@ "guid": "a66f0fd8-2ca4-422e-8df3-235148127ca2", "id": "A01.54", "severity": "High", - "graph": "resources | where type == "microsoft.network/applicationgateways"| extend compliant = (properties['backendHttpSettingsCollection'][0]['properties']['port'] == "443") |where properties['backendHttpSettingsCollection'][0]['properties']['port'] == "443" |distinct id,name,compliant", + "graph": "resources | where type == "microsoft.network/applicationgateways"| extend compliant = (properties['backendHttpSettingsCollection'][0]['properties']['port'] =~ "443") |where properties['backendHttpSettingsCollection'][0]['properties']['port'] =~ "443" |distinct id,name,compliant", "link": "https://learn.microsoft.com/azure/application-gateway/ssl-overview" }, From 5c78308b368eaa392a9f7e49797e2f3610c08471 Mon Sep 17 00:00:00 2001 From: asukumar22 <70966383+asukumar22@users.noreply.github.com> Date: Mon, 23 Sep 2024 08:17:23 -0700 Subject: [PATCH 4/4] Update network_appdelivery_checklist.en.json Added single quotes for strings inside ARG query --- checklists/network_appdelivery_checklist.en.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checklists/network_appdelivery_checklist.en.json b/checklists/network_appdelivery_checklist.en.json index 13fbb8daa..d455d8ab8 100644 --- a/checklists/network_appdelivery_checklist.en.json +++ b/checklists/network_appdelivery_checklist.en.json @@ -342,7 +342,7 @@ "guid": "a66f0fd8-2ca4-422e-8df3-235148127ca2", "id": "A01.54", "severity": "High", - "graph": "resources | where type == "microsoft.network/applicationgateways"| extend compliant = (properties['backendHttpSettingsCollection'][0]['properties']['port'] =~ "443") |where properties['backendHttpSettingsCollection'][0]['properties']['port'] =~ "443" |distinct id,name,compliant", + "graph": "resources | where type == 'microsoft.network/applicationgateways'| extend compliant = (properties['backendHttpSettingsCollection'][0]['properties']['port'] =~ '443') |where properties['backendHttpSettingsCollection'][0]['properties']['port'] =~ '443'|distinct id,name,compliant", "link": "https://learn.microsoft.com/azure/application-gateway/ssl-overview" },