You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feat: CSE-based bootstrapping with bootstrapping client mode (#527)
* chore: update devcontainer go version
* chore: refresh toolcain
* chore: additional processing on verify
(and migration to kube-system)
* chore: bump dependencies
* chore: refresh Helm charts
* chore: update golangci config
* chore: remove feature gate for drift
* chore: update pre-commit tooling
* chore: update the shape of main
* chore: update the alt operator
* chore: update the API (move kubelet config to AKSNodeClass)
* chore: migrate cloud provider to v1 API
* chore: migrate operator to v1 API
* chore: migrate controllers to v1 API
* chore: add nodeclass status controller
* chore: migrate providers to v1 API
* chore: migrate test pkg to v1 API
* chore: update utils
* chore: update and migrate E2E tests to v1 API
* feat: refresh and relink CRDs
* fix: move code generation into subfolders to fix golangci-lint
(typecheck detecting multiple main.go)
* fix: enable most of govet in golangci
* fix(linting): exclude alt operator logger
* fix: add nodeclass termination controller
* fix(lint): restore linting on verify
* feat: add nodeclass hash controller
* fix: register additional nodeclass and status controllers
* fix(e2e): better selection of karpenter pod for logs
* fix(e2e): fix utilization suite
* chore(e2e): add events to dump-logs (and simplify)
* chore: rename v1 to corev1
* fix: remove extra $
* fix(e2e): add cilium label and taint
* fix(e2e): fix labels and disruption for deamonset test
* feat: update kubelet configuration
* fix: conflicting nodeclaim.garbagecollcation controller name
* chore: restore webhooks in alt operator
* Clean up commented out webhook code
* chore: swagger spec for nodebootstrapping GET and autogenerated client
* feat: bootstrapping client provision mode
* chore: general code improvements
* fix: required VnetCidrs wasn't populated
* chore: read error response as text
* fix: handle the issue of mismatched error format in response body/header
* chore: more accurate overhead subtraction for instancetype
* fix: correct VM memory passing
* test: some unit tests and improvements
* chore: linter changes and small improvements
* feat: makefile command for swagger client generation
* chore: remove unused parameters in readResponse()
* fix: swagger binary not found
* chore: small improvements
* chore: added missing fullstops in other env descriptions
* chore: rename bootstrapping types to scriptless and customscripts to align with AgentBaker
* fix(test): fix test for credential provider URL in custom data
* Make webhooks work in AKS CCP context (#537)
This requires quite a bit of hacking, mostly overriding certain things
in the ctx. The major items are:
* Copy and modify knative/pkg/webhook/resourcesemantics/conversion to
support CRD clientConfig.url in addition to clientConfig.service.
* Copy and modify karpenter/pkg/webhooks/webhooks.go to support
overriding the informer factory, so that we can point it at the
CCP APIServer rather than overlay.
* Override Start and supporting methods on the provider specific
operator in pkg/operator/operator.go to allow invoking our modified
version of karpenter/pkg/webhooks/webhooks.go.
* chore: MaxPods is already defaulted
* chore: remove failSwapOn from kubelet settings in AKSNodeClass
* fix: populate nodeClaim.Status.ImageID
* fix: record NodeClass hash and add drift on static fields
* chore: rename variabled
* fix: remove outdated comment
* fix: typo
* chore: update CRDs
* feat: support custom kubeletconfig per v1
* chore: ignore false positive golint overflow check
* test: fix option for provision mode in testing
---------
Co-authored-by: tallaxes <[email protected]>
Co-authored-by: Matthew Christopher <[email protected]>
Copy file name to clipboardExpand all lines: pkg/operator/options/options.go
+8-4Lines changed: 8 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -75,7 +75,9 @@ type Options struct {
75
75
SubnetIDstring// => VnetSubnetID to use (for nodes in Azure CNI Overlay and Azure CNI + pod subnet; for for nodes and pods in Azure CNI), unless overridden via AKSNodeClass
@@ -85,12 +87,14 @@ func (o *Options) AddFlags(fs *coreoptions.FlagSet) {
85
87
fs.StringVar(&o.KubeletClientTLSBootstrapToken, "kubelet-bootstrap-token", env.WithDefaultString("KUBELET_BOOTSTRAP_TOKEN", ""), "[REQUIRED] The bootstrap token for new nodes to join the cluster.")
86
88
fs.StringVar(&o.SSHPublicKey, "ssh-public-key", env.WithDefaultString("SSH_PUBLIC_KEY", ""), "[REQUIRED] VM SSH public key.")
87
89
fs.StringVar(&o.NetworkPlugin, "network-plugin", env.WithDefaultString("NETWORK_PLUGIN", consts.NetworkPluginAzure), "The network plugin used by the cluster.")
88
-
fs.StringVar(&o.NetworkPluginMode, "network-plugin-mode", env.WithDefaultString("NETWORK_PLUGIN_MODE", consts.NetworkPluginModeOverlay), "network plugin mode of the cluster")
90
+
fs.StringVar(&o.NetworkPluginMode, "network-plugin-mode", env.WithDefaultString("NETWORK_PLUGIN_MODE", consts.NetworkPluginModeOverlay), "network plugin mode of the cluster.")
89
91
fs.StringVar(&o.NetworkPolicy, "network-policy", env.WithDefaultString("NETWORK_POLICY", ""), "The network policy used by the cluster.")
90
92
fs.StringVar(&o.NetworkDataplane, "network-dataplane", env.WithDefaultString("NETWORK_DATAPLANE", "cilium"), "The network dataplane used by the cluster.")
91
-
fs.StringVar(&o.SubnetID, "vnet-subnet-id", env.WithDefaultString("VNET_SUBNET_ID", ""), "The default subnet ID to use for new nodes. This must be a valid ARM resource ID for subnet that does not overlap with the service CIDR or the pod CIDR")
93
+
fs.StringVar(&o.SubnetID, "vnet-subnet-id", env.WithDefaultString("VNET_SUBNET_ID", ""), "The default subnet ID to use for new nodes. This must be a valid ARM resource ID for subnet that does not overlap with the service CIDR or the pod CIDR.")
92
94
fs.Var(newNodeIdentitiesValue(env.WithDefaultString("NODE_IDENTITIES", ""), &o.NodeIdentities), "node-identities", "User assigned identities for nodes.")
93
-
fs.StringVar(&o.NodeResourceGroup, "node-resource-group", env.WithDefaultString("AZURE_NODE_RESOURCE_GROUP", ""), "[REQUIRED] the resource group created and managed by AKS where the nodes live")
95
+
fs.StringVar(&o.NodeResourceGroup, "node-resource-group", env.WithDefaultString("AZURE_NODE_RESOURCE_GROUP", ""), "[REQUIRED] the resource group created and managed by AKS where the nodes live.")
96
+
fs.StringVar(&o.ProvisionMode, "provision-mode", env.WithDefaultString("PROVISION_MODE", consts.ProvisionModeAKSScriptless), "[UNSUPPORTED] The provision mode for the cluster.")
97
+
fs.StringVar(&o.NodeBootstrappingServerURL, "nodebootstrapping-server-url", env.WithDefaultString("NODEBOOTSTRAPPING_SERVER_URL", ""), "[UNSUPPORTED] The url for the node bootstrapping provider server.")
0 commit comments