Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/ptn/maintenance/azure-update-manager #1144

Open
2 tasks done
psinnathurai opened this issue Jun 26, 2024 · 22 comments · May be fixed by Azure/bicep-registry-modules#3771
Open
2 tasks done

[Module Proposal]: avm/ptn/maintenance/azure-update-manager #1144

psinnathurai opened this issue Jun 26, 2024 · 22 comments · May be fixed by Azure/bicep-registry-modules#3771
Assignees
Labels
Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Status: External Contribution 🌍 This is being worked on by someone outside of the AVM module owners/contributors or AVM core team Status: In PR 👉 This is when an issue is due to be fixed in an open PR Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@psinnathurai
Copy link

psinnathurai commented Jun 26, 2024

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/maintenance/azure-update-manager

Module Details

I would like to have a Pattern Module for Azure Update Manager which creates multiple Maintenance Windows to provide multiple Update Rings. The Maintenance Windows should use a Dynamic Scope in Combination of a Tag. In this Module it should also include also the needed Azure Policies to deploy the needed Policy for AUM and for the Tag Deployment to make sure that every Azure VM and Azure Arc Enabled Server has the specific Tag defined as Required. This make sure that every server will be part of a Maintenance Window in AUM. For the Azure Policy it will also create managed Identity.

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

akhilthomas011

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@psinnathurai psinnathurai added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Jun 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Language: Bicep 💪 This is related to the Bicep IaC language Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Jun 26, 2024
@matebarabas
Copy link
Contributor

Hi @psinnathurai, thanks for proposing this module! Is this something you'd be interested in contributing to? Do you by any chance even have any code for this solution already? Please let us know! Thanks!

@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Pattern Module 📦 This is a pattern module labels Jun 27, 2024
@psinnathurai
Copy link
Author

psinnathurai commented Jun 28, 2024

Hi @matebarabas
This is something I would be interested in contributing. As of now I don't have any code solution ready.

@matebarabas matebarabas added the Status: External Contribution 🌍 This is being worked on by someone outside of the AVM module owners/contributors or AVM core team label Jun 28, 2024
@matebarabas matebarabas moved this from Proposed to Looking for owners in AVM - Module Triage Jun 28, 2024
@matebarabas
Copy link
Contributor

Thank you, @psinnathurai, for confirming you'd be interested in contributing to this module!

In order to appropriate triage this proposal, we need to go through a couple of standard questions and also finalize its name. I'll help with these steps.
Then, we can advertise it within the Microsoft community, to find a Microsoft FTE module owner who you can then work with. Just to set your expectations: this can take a long(er) time, but we'll do everything we can to draw attention to it.

For pattern modules, we're always asking the person who proposes them to address these questions. Since you've already provided the context pretty well, I'd only like to ask you to further elaborate specifically on what resources would be part of this solution, and if possible, include a logical diagram that shows the architecture.

Thank you!

@ChrisSidebotham
Copy link
Contributor

Hi @psinnathurai - Have you had chance to review the reply from @matebarabas above?

@psinnathurai
Copy link
Author

Hi @ChrisSidebotham

I just saw the answer from @matebarabas. I will create a architecture diagram in until the end of next month. (Just came back from the Holidays and need to check on few other things first.)

@psinnathurai
Copy link
Author

Azure Update Manager AVM Pattern Module drawio

I have added a logical Diagram on how I would image this Pattern Module would look like.
I just did it on a example Subscription but this can be forwarded to multiple Subscriptions.

@matebarabas
Copy link
Contributor

Hi @psinnathurai, thank you for getting back to us with this diagram! Just for added clarity, can you please also assign labels to the objects in the bottom resource group? Thank you!

Regarding this module's name, I'd recommend something like avm/ptn/maintenance/azure-update-manager. Would you have any other suggestions, or do you think this would make sense?

Regarding finding an FTE owner, we don't yet have an update unfortunately, but we'll have an upcoming event, where we'll try to draw more attention to those modules that don't yet have an owner. Can I please ask you if you'd like to start working on the code while we're waiting for a Microsoft FTE to volunteer?

@psinnathurai
Copy link
Author

Hi @matebarabas

I have updated the Diagram.

Azure Update Manager AVM Pattern Module drawio

The name sounds fine!

Sure, I will start working on that code.

@matebarabas matebarabas changed the title [Module Proposal]: Azure Update Manager [Module Proposal]: avm/ptn/maintenance/azure-update-manager Aug 28, 2024
@matebarabas
Copy link
Contributor

@psinnathurai, I've updated the issue's title and description with the proposed name.

The diagram still seems to miss the labels from under the bottom 3 resources in the bottom RG. Is there a chance that this gets lost in translation when you're exporting it from the tool you're using?

@psinnathurai
Copy link
Author

Azure Update Manager AVM Pattern Module drawio (1)

Now it should work :-)

@akhilthomas011
Copy link

@psinnathurai, have you started working on the code for this pattern? If not, I could take this over.

@psinnathurai
Copy link
Author

psinnathurai commented Sep 14, 2024

@akhilthomas011 unfortunately I didn't start yet. Feel free to start.
I guess it also makes sense to add Event Hub for Pre and Post Events into this Pattern

@matebarabas
Copy link
Contributor

Hi @akhilthomas011,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Sep 18, 2024
@akhilthomas011
Copy link

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Sep 18, 2024
@matebarabas
Copy link
Contributor

Hi @akhilthomas011,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Sep 18, 2024
@matebarabas matebarabas removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Needs: Module Owner 📣 This module needs an owner to develop or maintain it Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Sep 18, 2024
@matebarabas matebarabas moved this from Looking for owners to In development in AVM - Module Triage Sep 18, 2024
@akhilthomas011
Copy link

Hi @matebarabas , I don't think this pattern is indexed in the module index page. I'm not able to get the details of it.

@matebarabas
Copy link
Contributor

@akhilthomas011, it's not yet. I'll update the index later today. Thanks for your patience!

Important

@akhilthomas011, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Oct 10, 2024
@akhilthomas011
Copy link

A draft pattern is near to completion. I will get it reviewed once done.

@matebarabas matebarabas removed the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Oct 14, 2024
@matebarabas
Copy link
Contributor

Thanks for the update, @akhilthomas011! Please provide a link to the PR, once it's available. Thank you!

Important

@akhilthomas011, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Nov 4, 2024
@akhilthomas011
Copy link

@matebarabas - Here is the PR: Azure/bicep-registry-modules#3771

@matebarabas matebarabas added Status: In PR 👉 This is when an issue is due to be fixed in an open PR and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Nov 12, 2024
@matebarabas matebarabas moved this from In development to In Review in AVM - Module Triage Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Status: External Contribution 🌍 This is being worked on by someone outside of the AVM module owners/contributors or AVM core team Status: In PR 👉 This is when an issue is due to be fixed in an open PR Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

4 participants