-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module Proposal]: avm/ptn/maintenance/azure-update-manager
#1144
[Module Proposal]: avm/ptn/maintenance/azure-update-manager
#1144
Comments
Hi @psinnathurai, thanks for proposing this module! Is this something you'd be interested in contributing to? Do you by any chance even have any code for this solution already? Please let us know! Thanks! |
Hi @matebarabas |
Thank you, @psinnathurai, for confirming you'd be interested in contributing to this module! In order to appropriate triage this proposal, we need to go through a couple of standard questions and also finalize its name. I'll help with these steps. For pattern modules, we're always asking the person who proposes them to address these questions. Since you've already provided the context pretty well, I'd only like to ask you to further elaborate specifically on what resources would be part of this solution, and if possible, include a logical diagram that shows the architecture. Thank you! |
Hi @psinnathurai - Have you had chance to review the reply from @matebarabas above? |
I just saw the answer from @matebarabas. I will create a architecture diagram in until the end of next month. (Just came back from the Holidays and need to check on few other things first.) |
Hi @psinnathurai, thank you for getting back to us with this diagram! Just for added clarity, can you please also assign labels to the objects in the bottom resource group? Thank you! Regarding this module's name, I'd recommend something like Regarding finding an FTE owner, we don't yet have an update unfortunately, but we'll have an upcoming event, where we'll try to draw more attention to those modules that don't yet have an owner. Can I please ask you if you'd like to start working on the code while we're waiting for a Microsoft FTE to volunteer? |
Hi @matebarabas I have updated the Diagram. The name sounds fine! Sure, I will start working on that code. |
Azure Update Manager
avm/ptn/maintenance/azure-update-manager
@psinnathurai, I've updated the issue's title and description with the proposed name. The diagram still seems to miss the labels from under the bottom 3 resources in the bottom RG. Is there a chance that this gets lost in translation when you're exporting it from the tool you're using? |
@psinnathurai, have you started working on the code for this pattern? If not, I could take this over. |
@akhilthomas011 unfortunately I didn't start yet. Feel free to start. |
Hi @akhilthomas011, Thanks for requesting/proposing to be an AVM module owner! We just want to confirm you agree to the below pages that define what module ownership means: Any questions or clarifications needed, let us know! If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍): "I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER" Thanks, The AVM Core Team #RR |
I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER |
Hi @akhilthomas011, Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities! Before starting development, please ensure ALL the following requirements are met. Please use the following values explicitly as provided in the module index page:
Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍 You can now start the development of this module! ✅ Happy coding! 🎉 Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏 Any further questions or clarifications needed, let us know! Thanks, The AVM Core Team |
Hi @matebarabas , I don't think this pattern is indexed in the module index page. I'm not able to get the details of it. |
@akhilthomas011, it's not yet. I'll update the index later today. Thanks for your patience! |
Important @akhilthomas011, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module. Tip To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label. |
A draft pattern is near to completion. I will get it reviewed once done. |
Thanks for the update, @akhilthomas011! Please provide a link to the PR, once it's available. Thank you! |
Important @akhilthomas011, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module. Tip To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label. |
@matebarabas - Here is the PR: Azure/bicep-registry-modules#3771 |
Check for previous/existing GitHub issues/module proposals
Check this module doesn't already exist in the module indexes
Bicep or Terraform?
Bicep
Module Classification?
Pattern Module
Module Name
avm/ptn/maintenance/azure-update-manager
Module Details
I would like to have a Pattern Module for Azure Update Manager which creates multiple Maintenance Windows to provide multiple Update Rings. The Maintenance Windows should use a Dynamic Scope in Combination of a Tag. In this Module it should also include also the needed Azure Policies to deploy the needed Policy for AUM and for the Tag Deployment to make sure that every Azure VM and Azure Arc Enabled Server has the specific Tag defined as Required. This make sure that every server will be part of a Maintenance Window in AUM. For the Azure Policy it will also create managed Identity.
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
akhilthomas011
(Optional) Secondary Module Owner's GitHub Username (handle)
No response
The text was updated successfully, but these errors were encountered: