Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVM Module Issue]: Unable to create cache rule with CredentialSetResourceId #3741

Open
1 task done
ChrisSidebotham opened this issue Nov 6, 2024 · 7 comments · May be fixed by #3764 or #3742
Open
1 task done

[AVM Module Issue]: Unable to create cache rule with CredentialSetResourceId #3741

ChrisSidebotham opened this issue Nov 6, 2024 · 7 comments · May be fixed by #3764 or #3742
Assignees
@JPEasier
Labels
Class: Resource Module 📦 This is a resource module Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@ChrisSidebotham
Copy link
Contributor

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/container-registry/registry

(Optional) Module Version

0.6.0

Description

When leveraging Cache Rules from a Public Registry (e.g mcr.microsoft.com) a credential set is not needed. using the ARM Resource Modules this is possible, but the AVM Template seems to require a credentialsetresourceid to be passed

(Optional) Correlation Id

No response
@ChrisSidebotham ChrisSidebotham added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Nov 6, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Nov 6, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Nov 6, 2024
@avm-team-linter AVM Team Linter
Copy link

@ChrisSidebotham, thanks for submitting this issue for the avm/res/container-registry/registry module!

Important

A member of the @Azure/avm-res-containerregistry-registry-module-owners-bicep or @Azure/avm-res-containerregistry-registry-module-contributors-bicep team will review it soon!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Nov 6, 2024
ChrisSidebotham added a commit to ChrisSidebotham/bicep-registry-modules that referenced this issue Nov 6, 2024
@ChrisSidebotham
Fix for Azure#3741
1412622
@ChrisSidebotham ChrisSidebotham linked a pull request Nov 6, 2024 that will close this issue
Draft
11 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Nov 11, 2024
@seesharprun
Copy link
Contributor

I'm experiencing the same issue. I'm trying to create a cache rule for Microsoft Container Registry and a credentialSetResourceId. It's not possible to define a credential set for MCR. Ideally, a rule like this should work:

cacheRules: [
  {
    name: 'mcr-cache-rule'
    sourceRepository: 'mcr.microsoft.com/*'
    targetRepository: 'mcr/*'
  }
]

@seesharprun seesharprun linked a pull request Nov 11, 2024 that will close this issue
Open
17 tasks
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed label Nov 15, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

@seesharprun
Copy link
Contributor

I'm working on it in #3764, but I can't get this unit test to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JPEasier JPEasier

Labels
Class: Resource Module 📦 This is a resource module Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
AVM - Module Issues
Status: Needs: Triage
Milestone
No milestone
3 participants
@seesharprun @JPEasier @ChrisSidebotham