Releasing 1.0.14 (#656)

* Minor fix for aspnetcore 3.0 (#652)

* minor fix for aspnetcore 3.0

* retry UT.

* extend ack TTL to stable UT.

* Upgrade jwt and fix potential memory leak (#653)

* Update version to 1.0.14 (#648)

* Update version to 1.0.14

Author: JialinXin

build/dependencies.props

@@ -12,7 +12,7 @@
     <MicrosoftAzureKeyVaultPackageVersion>2.3.2</MicrosoftAzureKeyVaultPackageVersion>
     <SystemBuffersPackageVersion>4.5.0</SystemBuffersPackageVersion>
     <SystemMemoryPackageVersion>4.5.0</SystemMemoryPackageVersion>
-    <SystemIdentityModelTokensJwtPackageVersion>5.2.1</SystemIdentityModelTokensJwtPackageVersion>
+    <SystemIdentityModelTokensJwtPackageVersion>5.5.0</SystemIdentityModelTokensJwtPackageVersion>
     <MicrosoftExtensionsDependencyInjectionPackageVersion>2.1.0</MicrosoftExtensionsDependencyInjectionPackageVersion>
     <MicrosoftExtensionsLoggingPackageVersion>2.1.0</MicrosoftExtensionsLoggingPackageVersion>
     <MicrosoftExtensionsPrimitivesPackageVersion>2.1.0</MicrosoftExtensionsPrimitivesPackageVersion>

src/Microsoft.Azure.SignalR.Common/ServiceConnections/ConnectionFactory.cs

@@ -76,7 +76,7 @@ public Task DisposeAsync(ConnectionContext connection)
             {
                 return Task.CompletedTask;
             }
-#if !NETCOREAPP3_0
+#if NETSTANDARD2_0
             return ((HttpConnection)connection).DisposeAsync();
 #else
             return ((HttpConnection)connection).DisposeAsync().AsTask();

src/Microsoft.Azure.SignalR.Common/Utilities/AuthenticationHelper.cs

@@ -68,7 +68,10 @@ private static string GenerateJwtBearer(
             SigningCredentials credentials = null;
             if (!string.IsNullOrEmpty(signingKey))
             {
+                // Refer: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases/tag/5.5.0
+                // From version 5.5.0, SignatureProvider caching is turned On by default, assign KeyId to enable correct cache for same SigningKey
                 var securityKey = new SymmetricSecurityKey(Encoding.UTF8.GetBytes(signingKey));
+                securityKey.KeyId = signingKey;
                 credentials = new SigningCredentials(securityKey, SecurityAlgorithms.HmacSha256);
             }
 

src/Microsoft.Azure.SignalR/DependencyInjectionExtensions.cs

@@ -81,7 +81,7 @@ private static ISignalRServerBuilder AddAzureSignalRCore(this ISignalRServerBuil
             builder.Services.TryAddSingleton(typeof(IEndpointRouter), typeof(DefaultEndpointRouter));
             builder.Services.TryAddSingleton(typeof(IConnectionRequestIdProvider), typeof(DefaultConnectionRequestIdProvider));
 
-#if NETCOREAPP3_0
+#if !NETSTANDARD2_0
             builder.Services.TryAddSingleton<AzureSignalRHostedService>();
             builder.Services.TryAddEnumerable(ServiceDescriptor.Singleton<IStartupFilter, AzureSignalRStartupFilter>());
             builder.Services.TryAddEnumerable(ServiceDescriptor.Singleton<MatcherPolicy, NegotiateMatcherPolicy>());

src/Microsoft.Azure.SignalR/HubHost/ServiceHubConnectionContext.cs

@@ -30,7 +30,7 @@ internal class ServiceHubConnectionContext : HubConnectionContext
         public const string ItemsUnavailableError = nameof(Items) + UnavailableErrorTemplate;
         public const string ProtocolUnavailableError = nameof(Protocol) + UnavailableErrorTemplate;
 
-#if NETCOREAPP3_0
+#if !NETSTANDARD2_0
         public ServiceHubConnectionContext(HttpContext context)
             : base(new DummyConnectionContext(context), 
                   new HubConnectionContextOptions() { KeepAliveInterval = TimeSpan.MaxValue }, 

src/Microsoft.Azure.SignalR/HubHost/ServiceLifetimeManager.cs

@@ -28,7 +28,7 @@ public ServiceLifetimeManager(IServiceConnectionManager<THub> serviceConnectionM
             : base(serviceConnectionManager, protocolResolver)
         {
             // after core 3.0 UseAzureSignalR() is not required.
-#if !NETCOREAPP3_0
+#if NETSTANDARD2_0
             if (!marker.IsConfigured)
             {
                 throw new InvalidOperationException(MarkerNotConfiguredError);

src/Microsoft.Azure.SignalR/Startup/AzureSignalRHostedService.cs

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-#if NETCOREAPP3_0
+#if !NETSTANDARD2_0
 using System;
 using Microsoft.AspNetCore.Connections;
 using Microsoft.AspNetCore.Http.Connections;

src/Microsoft.Azure.SignalR/Startup/AzureSignalRHostingStartup.cs

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-#if NETCOREAPP3_0
+#if !NETSTANDARD2_0
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.Azure.SignalR;
 using Microsoft.Extensions.Configuration;

src/Microsoft.Azure.SignalR/Startup/AzureSignalRStartupFilter.cs

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-#if NETCOREAPP3_0
+#if !NETSTANDARD2_0
 using System;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Hosting;

src/Microsoft.Azure.SignalR/Startup/NegotiateMatcherPolicy.cs

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-#if NETCOREAPP3_0
+#if !NETSTANDARD2_0
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Threading.Tasks;
@@ -62,6 +62,9 @@ private Endpoint CreateNegotiateEndpoint(Endpoint endpoint)
             routeEndpoint.RoutePattern,
             routeEndpoint.Order);
 
+            // Set DisplayName
+            routeEndpointBuilder.DisplayName = routeEndpoint.DisplayName;
+
             // Preserve the metadata
             foreach (var metadata in endpoint.Metadata)
             {