Bug for _index_documents_actions when the batch is too large

[HuskyDanny]

• Package Name: azure-search-documents==11.5.2
• Package Version: azure-search-documents==11.5.2
• Operating System: Linux
• Python Version: python 3.10

Describe the bug
The exception's handling will trigger keyerror for error_map
Function: def _index_documents_actions(self, actions: List[IndexAction], **kwargs: Any) -> List[IndexingResult]:

The key reason is the index() function will expect to pop error_map from kwargs, so you have to include it in the kwargs
To Reproduce
Steps to reproduce the behavior:

1. Simply read a json file over 2k documents and upload the documents
   `

read json file

with open(json_file_path, "r") as file:
    documents = json.load(file)

search_client = SearchClient(
    endpoint=service_endpoint, index_name=index_name, credential=credential
)

result = search_client.upload_documents(documents=documents)

`

Expected behavior
Items should be splitted by half and get inserted to the index

Screenshots

Additional context
I fixed the hanlding by having the error_map in the kwargs:

`

def _index_documents_actions(self, actions: List[IndexAction], **kwargs: Any) -> List[IndexingResult]:
error_map = {413: RequestEntityTooLargeError}
kwargs["headers"] = self._merge_client_headers(kwargs.get("headers"))
kwargs["error_map"] = error_map
batch = IndexBatch(actions=actions)
try:
batch_response = self._client.documents.index(batch=batch, **kwargs)
return cast(List[IndexingResult], batch_response.results)
except RequestEntityTooLargeError:
if len(actions) == 1:
raise
pos = round(len(actions) / 2)
batch_response_first_half = self._index_documents_actions(
actions=actions[:pos], **kwargs
)
if batch_response_first_half:
result_first_half = batch_response_first_half
else:
result_first_half = []
batch_response_second_half = self._index_documents_actions(
actions=actions[pos:], **kwargs
)
if batch_response_second_half:
result_second_half = batch_response_second_half
else:
result_second_half = []
result_first_half.extend(result_second_half)
return result_first_half

`

[xiangyan99]

Thanks for the feedback, we’ll investigate asap.

[xiangyan99]

I am not quite clear.

Seems like you proposed to change
batch_response = self._client.documents.index(batch=batch, error_map=error_map, **kwargs)

to
kwargs["error_map"] = error_map
batch_response = self._client.documents.index(batch=batch, **kwargs)

I don't see how it makes difference.

[github-actions]

Hi @HuskyDanny. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.