Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in validation BatchDeploymentSchema #33044

Closed
asos-rickbruins opened this issue Nov 8, 2023 · 5 comments
Closed

Bug in validation BatchDeploymentSchema #33044

asos-rickbruins opened this issue Nov 8, 2023 · 5 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@asos-rickbruins
Copy link

asos-rickbruins commented Nov 8, 2023

  • Package Name: azure-ai-ml
  • Package Version: 1.11.1
  • Operating System: Linux 23.10.09
  • Python Version: 3.8.10

Describe the bug
Validation error for BatchDeploymentSchema when using the field "settings". However, it is listed as a valid key in the yaml schema, see documentation

To Reproduce
Steps to reproduce the behavior:

deployment.yaml

$schema: https://azuremlschemasprod.azureedge.net/latest/batchDeployment.schema.json
name: collaborative-filtering-train
description: Train CF model and save embeddings
endpoint_name: collaborative-filtering-train
type: pipeline
component: ./pipeline.yaml
settings:
  continue_on_step_failure: false
  force_rerun: true
from azure.ai.ml import load_batch_deployment

deployment = load_batch_deployment("deployment.yaml")

Error

marshmallow.exceptions.ValidationError: {'settings': ['Unknown field.']}

Expected behavior
No error, because the key is valid.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 8, 2023
@kristapratico kristapratico added Machine Learning Service Attention Workflow: This issue is responsible by Azure service team. Client This issue points to a problem in the data-plane of the library. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 8, 2023
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @azureml-github @Azure/azure-ml-sdk.

@kristapratico
Copy link
Member

@asos-rickbruins thanks for your feedback, @azureml-github will take a look and get back to you as soon as possible.

@asos-rickbruins
Copy link
Author

Any update?

@santiagxf
Copy link
Member

Apologies for the delay in getting back to you @asos-rickbruins. https://azuremlschemasprod.azureedge.net/latest/batchDeployment.schema.json is our legacy schema for model batch deployments. Please use https://azuremlschemas.azureedge.net/latest/pipelineComponentBatchDeployment.schema.json for pipeline component deployments. I'm updating the documentation so it reflects the right schema.

@santiagxf
Copy link
Member

Examples has been updated in the PR: Azure/azureml-examples#2962

@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Machine Learning needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

4 participants