Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aztables] Remove odd env variables stored in eng/config.json #23603

Open
richardpark-msft opened this issue Oct 18, 2024 · 0 comments
Open

[aztables] Remove odd env variables stored in eng/config.json #23603

richardpark-msft opened this issue Oct 18, 2024 · 0 comments

Comments

@richardpark-msft
Copy link
Member

(This came up in #23596)

There are some hardcoded variables for the CosmoDB emulator that are stored in eng/config.json that get injected into the CI pipeline. Injecting these via config.json is a technique that nobody uses, so it confused everyone and (since it's a JSON file without comments) it's not obvious what those values are for.

It'd be better to move them locally, into the test, rather than having them be stored for both data and now, data/aztables.

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 18, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 18, 2024
@richardpark-msft richardpark-msft added this to the Backlog milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants