Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] firewallPolicy draft and rule collection group draft should be sub resource for its corresponding policy resource. #31857

Open
hqhqhqhqhqhqhqhqhqhqhq opened this issue Dec 12, 2024 · 1 comment
Open

[FEATURE REQ] firewallPolicy draft and rule collection group draft should be sub resource for its corresponding policy resource. #31857

hqhqhqhqhqhqhqhqhqhqhq opened this issue Dec 12, 2024 · 1 comment
Assignees
@GuptaVertika
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@hqhqhqhqhqhqhqhqhqhqhq
Copy link

API Spec link

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/firewallPolicy.json

API Spec version

2023-11-01

Please describe the feature.

Hi, with the current spec design, it seems like both firewallPolicy draft and rule collection group draft have its own CRUD APIs, but they should be treated like other sub-resources (same as rule collection group): policy draft as a sub resource of policy, and rule collection group draft as a sub-resource of rule collection group (which itself is a sub-resource of firewallpolicy).

i.e. The structure should be:
firewallPolicy
a. firewallPolicy draft
b. rule collection group
(1). rule collection group draft

References

hashicorp/go-azure-sdk#1055

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/network/resource-manager/Microsoft.Network/stable/2023-11-01/firewallPolicy.json

https://pkg.go.dev/github.com/hashicorp/go-azure-sdk/[email protected]/network/2023-11-01
@hqhqhqhqhqhqhqhqhqhqhq hqhqhqhqhqhqhqhqhqhqhq added the feature-request This issue requires a new behavior in the product in order be resolved. label Dec 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added question The issue doesn't require a change to the product in order to be resolved. Most issues start as that customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 12, 2024
@v-jiaodi v-jiaodi added the Mgmt This issue is related to a management-plane library. label Dec 17, 2024
@v-jiaodi
Copy link
Member

@GuptaVertika Please help take a look, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuptaVertika GuptaVertika

Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@v-jiaodi @GuptaVertika @hqhqhqhqhqhqhqhqhqhqhq