[Playwright-DevDiv-Service - Playwright] API Review

[azure-sdk]

New API Review meeting has been requested.

Service Name: Playwright-DevDiv-Service - Playwright
Review Created By: Vansh Singh
Review Date: 01/15/2025 09:00 AM PT
Release Plan: 1533
PR:
Hero Scenarios Link: here
Core Concepts Doc Link: here

Description:

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

[azure-sdk]

Meeting updated by Manivelu Rajendran

Service Name: Playwright-DevDiv-Service - Playwright
Review Created By: Vansh Singh
Review Date: 01/15/2025 09:00 AM PT
Release Plan: 1533
PR:
Hero Scenarios Link: here
Core Concepts Doc Link: here

Description: TBD

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

[mjmadhu]

Current PR for review - #31855

We had a thread opened earlier for similar changes with preview version that got closed with unmerged commits unfortunately (due to long absence from our side). We'd like to reactivate this discussion again as the GA for our product is planned next month. The PR was signed off though.

Madhuri Jain: Data Plane API Review Request for new api-version
posted in Azure API Stewardship Board / General on Thursday, May 30, 2024 11:51 AM

Old PR -
Release playwrighttesting microsoft.playwright testing preview/2024 06 01 preview by mjmadhu · Pull Request #29262 · Azure/azure-rest-api-specs

P.S. - We've an upcoming PR for another data plane service for the same product shortly.

[mikekistler]

@mjmadhu Please post in the Service API Toolset Teams channel to request help with whatever validation problems you are having with the existing branch.

[mjmadhu]

Thanks @mikekistler ! Raised the issue - https://teams.microsoft.com/l/message/19:[email protected]/1734244622195?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=null&parentMessageId=1734244622195&teamName=Azure%20SDK&channelName=Service%20API%20Toolset&createdTime=1734244622195

[mjmadhu]

The TypeSpec Validation error is fixed now. Thanks @mikeharder for guiding there.
The Swagger LintDiff error is due to non standard HTTP response code 302 used in our API which was discussed in the context of previous PR earlier as a product requirement scenario and was signed off earlier.
Please help with further review and next steps to merge.

[mikeharder]

The TypeSpec Validation error is fixed now. Thanks @mikeharder for guiding there. The Swagger LintDiff error is due to non standard HTTP response code 302 used in our API which was discussed in the context of previous PR earlier as a product requirement scenario and was signed off earlier. Please help with further review and next steps to merge.

For LintDiff, you need to add a suppression to your readme.md. If this was signed off earlier, the suppression should have been added to your readme.md at that time.

https://eng.ms/docs/products/azure-developer-experience/design/specs-pr-guides/pr-suppressions#suppress-autorest-extension