[Azure Key Vault - Key Vault] API Review

[azure-sdk]

New API Review meeting has been requested.

Service Name: Azure Key Vault - Key Vault
Review Created By: Sandeep Sen
Review Date: 12/03/2024 01:00 PM PT
Release Plan: 1452
PR:
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description:

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

[azure-sdk]

Meeting updated by Sandeep Sen

Service Name: Azure Key Vault - Key Vault
Review Created By: Sandeep Sen
Review Date: 12/03/2024 01:00 PM PT
Release Plan: 1452
PR: #31670
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description:

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

[azure-sdk]

Meeting updated by Sandeep Sen

Service Name: Azure Key Vault - Key Vault
Review Created By: Sandeep Sen
Review Date: 12/03/2024 01:00 PM PT
Release Plan: 1452
PR: #31670
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description:

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

[mikekistler]

Notes from API Review 12/3/2024

• The key-version is passed in the path but not marked required.
  • This is not allowed in OpenAPI
  • It actually is optional. Here and everywhere else (even though it's marked required)
  • Jeff recommends making this two separate operations
• Moving to date-based versioning ?
  • Maybe plan to do this as part of the TypeSpec conversion ?
  • We would like the service to move to date-based versions in this api version
• It needs to be clear what encoding scheme is used for base64 fields
  • URL safe?
• Why "certificates" a plural name for a string?
  • It contains a base64url encoded PEM file that contains multiple certificates.
  • Consider changing this to "PEMfile" or something else
• Please specify that the default of preserveCertOrder parameter is false with default: false
  • Is the customer expected to respect this field ?
    • Why return it?
    • It's just for verification
  • Recommend removing the "must" from the description

This looks good for preview.