Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeviceNotOnline to error codes #3444

Closed
wants to merge 2 commits into from
Closed

Conversation

pregress
Copy link

Checklist

  • I have read the contribution guidelines.
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • This pull-request is submitted against the main branch.

Description of the changes

Added the error code: 404103 for Device online. So users can handle this error gracefully.

Reference/Link to the issue solved with this PR (if any)

Fixes: #3442

@timtay-microsoft
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pregress
Copy link
Author

Any reason why .NET 6 pipelines fail? Can't view the error since it azure devops.

@timtay-microsoft
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@timtay-microsoft
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@timtay-microsoft
Copy link
Member

We have some security rules in place that make it so forked PRs (like this one) can't access the credentials we use during our integration testing. Could you convert these changes into a branch on this repo instead?

@pregress
Copy link
Author

pregress commented Apr 9, 2024

We have some security rules in place that make it so forked PRs (like this one) can't access the credentials we use during our integration testing. Could you convert these changes into a branch on this repo instead?

@timtay-microsoft I do not have permissions to create a branch on this repo

@timtay-microsoft
Copy link
Member

Ah, my apologies. I'll go ahead and create that branch for you. #3450 should be merged in shortly

@timtay-microsoft
Copy link
Member

Your fix has been merged in #3450, so I'll close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeviceNotFoundException results in InvalidErrorCode (404103)
2 participants