Skip to content

Commit 1c18566

Browse files
authored
[Client encryption]: Fixes missing files errors at time of nuget publishing. (#4896)
# Pull Request Template ## Description Updated the Microsoft.Azure.Cosmos.Encryption package and Microsoft.Azure.Cosmos.Encryption.Custom package so as to fix missing icon.png and license.txt errors when publishing these packages locally. ## Type of change Below the are the errors the project throws while publishing the nuget package. <img width="899" alt="image" src="https://github.com/user-attachments/assets/301ac421-93b8-4cd6-90aa-3a49f1a18d55"> <img width="932" alt="image" src="https://github.com/user-attachments/assets/b2a0ad13-ad13-4bd2-a659-2f21863b297b"> After the fix is implemented the nuget package publishes successfully. <img width="937" alt="image" src="https://github.com/user-attachments/assets/afc3d1c2-3d73-43f1-94c3-09c2061ba169"> <img width="954" alt="image" src="https://github.com/user-attachments/assets/a21cf018-070d-432f-b91f-ba13ad5d3cb8"> - [X] Bug fix (non-breaking change which fixes an issue) ## Closing issues To automatically close an issue: closes #IssueNumber
1 parent 37d6894 commit 1c18566

File tree

4 files changed

+20
-6
lines changed

4 files changed

+20
-6
lines changed
File renamed without changes.

Microsoft.Azure.Cosmos.Encryption.Custom/src/Microsoft.Azure.Cosmos.Encryption.Custom.csproj

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,8 @@
1313
<Title>Microsoft Azure Cosmos DB client-side encryption library for multi-tenant</Title>
1414
<PackageId>Microsoft.Azure.Cosmos.Encryption.Custom</PackageId>
1515
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
16-
<PackageLicenseUrl>https://aka.ms/netcoregaeula</PackageLicenseUrl>
16+
<PackageLicenseFile>LICENSE</PackageLicenseFile>
1717
<PackageProjectUrl>https://github.com/Azure/azure-cosmos-dotnet-v3</PackageProjectUrl>
18-
<PackageIconUrl>http://go.microsoft.com/fwlink/?LinkID=288890</PackageIconUrl>
1918
<GenerateDocumentationFile>true</GenerateDocumentationFile>
2019
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
2120
<PackageTags>microsoft;azure;cosmos;cosmosdb;documentdb;docdb;nosql;azureofficial;dotnetcore;netcore;netstandard;client;encryption;byok</PackageTags>
@@ -33,6 +32,14 @@
3332
<PackageReference Include="Microsoft.Azure.Cosmos" Version="3.41.0-preview.0" />
3433
</ItemGroup>
3534

35+
<ItemGroup>
36+
<None Include="..\..\LICENSE" Pack="true" PackagePath="" Visible="false" />
37+
</ItemGroup>
38+
39+
<ItemGroup>
40+
<None Include="..\..\Icon.png" Pack="true" PackagePath=""/>
41+
</ItemGroup>
42+
3643
<ItemGroup Condition=" '$(SdkProjectRef)' == 'True' ">
3744
<ProjectReference Include="..\..\Microsoft.Azure.Cosmos\src\Microsoft.Azure.Cosmos.csproj" />
3845
</ItemGroup>

Microsoft.Azure.Cosmos.Encryption/src/Microsoft.Azure.Cosmos.Encryption.csproj

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,8 @@
1717
<Title>Microsoft Azure Cosmos DB client-side encryption library</Title>
1818
<PackageId>Microsoft.Azure.Cosmos.Encryption</PackageId>
1919
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
20-
<PackageLicenseUrl>https://aka.ms/netcoregaeula</PackageLicenseUrl>
20+
<PackageLicenseFile>LICENSE</PackageLicenseFile>
2121
<PackageProjectUrl>https://github.com/Azure/azure-cosmos-dotnet-v3</PackageProjectUrl>
22-
<PackageIconUrl>http://go.microsoft.com/fwlink/?LinkID=288890</PackageIconUrl>
2322
<GeneratePackageOnBuild>false</GeneratePackageOnBuild>
2423
<GenerateDocumentationFile>true</GenerateDocumentationFile>
2524
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
@@ -28,11 +27,19 @@
2827
<ItemGroup>
2928
<AdditionalFiles Include="..\..\Microsoft.Azure.Cosmos\src\stylecop.json" Link="stylecop.json" />
3029
</ItemGroup>
31-
30+
3231
<ItemGroup Condition=" '$(SdkProjectRef)' != 'True' AND '$(IsPreview)' != 'True' ">
3332
<PackageReference Include="Microsoft.Azure.Cosmos" Version="[3.35.4,3.37.0]" />
3433
</ItemGroup>
3534

35+
<ItemGroup>
36+
<None Include="..\..\Icon.png" Pack="true" PackagePath=""/>
37+
</ItemGroup>
38+
39+
<ItemGroup>
40+
<None Include="..\..\LICENSE" Pack="true" PackagePath="" Visible="false" />
41+
</ItemGroup>
42+
3643
<ItemGroup Condition=" '$(SdkProjectRef)' != 'True' AND '$(IsPreview)' == 'True' ">
3744
<PackageReference Include="Microsoft.Azure.Cosmos" Version="3.37.0-preview" />
3845
</ItemGroup>

Microsoft.Azure.Cosmos/src/Microsoft.Azure.Cosmos.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151

5252
<ItemGroup>
5353
<AdditionalFiles Include="stylecop.json" />
54-
<None Include="Icon.png" Pack="true" PackagePath="\" />
54+
<None Include="..\..\Icon.png" Pack="true" PackagePath=""/>
5555
</ItemGroup>
5656

5757
<ItemGroup>

0 commit comments

Comments
 (0)