Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI Create Or Update a Container Group Action - unused parameters in the GA Designer are showing up in the underlying JSON. Causes execution to fail #5084

Open
mlee78 opened this issue Jul 8, 2024 · 0 comments · May be fixed by #6278
Open

ACI Create Or Update a Container Group Action - unused parameters in the GA Designer are showing up in the underlying JSON. Causes execution to fail #5084

mlee78 opened this issue Jul 8, 2024 · 0 comments · May be fixed by #6278
Assignees
@Eric-B-Wu

Comments

@mlee78
Copy link

mlee78 commented Jul 8, 2024 •
edited by github-actions bot
Loading

Describe the Bug with repro steps

  1. Create a consumption workflow
  2. Add a HTTP trigger
  3. Add a Create Or Update a Container Group action
  4. Add a ContainerGroup Container
  5. Click on Advanced Parameters
  6. Click on ContainerGroup Volumes
  7. Close that modal
  8. Click on Add New Item under ContainerGroup Volumes

At this point you can look at the JSON and see the issues:

Issue 1: Under containers->properties->resources there is an entry for gpu's. Even if no gpu is selected a value shows up in the json config. And when you execute this action you will receive an error saying a null value for count is not legal.

Issue 2: Under containers->properties->limits there is now an entry for gpu limits. Again this brings up an error due to a null value

Issue 3: Under containers->properties->livenessProbe there is a null value for exec. Even if you don't use a livenessProbe it shows up in the config and causes an error to occur when you execute it with a null value

Issue 4: Under containers->properties->readinessProbe there is a null value for exec. Even if you don't use a readinessProbe it shows up in the config and causes an error to occur when you execute it with a null value

Issue 5: Under containers->properties->volumes there is a gitRepo entry. If you don't use a git repo and try executing this action you will run into an error because of the null value under the repository key.

What type of Logic App Is this happening in?

Consumption (Portal)

Are you using new designer or old designer

New Designer

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

Yes

Workflow JSON

bob": {
            "type": "ApiConnection",
            "inputs": {
              "host": {
                "connection": {
                  "name": "@parameters('$connections')['aci-1']['connectionId']"
                }
              },
              "method": "put",
              "body": {
                "location": "a",
                "properties": {
                  "containers": [
                    {
                      "properties": {
                        "resources": {
                          "requests": {
                            "gpu": {
                              "count": null,
                              "sku": null
                            },
                            "memoryInGB": null,
                            "cpu": null
                          },
                          "limits": {
                            "gpu": {
                              "count": null,
                              "sku": null
                            }
                          }
                        },
                        "livenessProbe": {
                          "exec": {
                            "command": null
                          },
                          "httpGet": {
                            "port": null
                          }
                        },
                        "readinessProbe": {
                          "exec": {
                            "command": null
                          },
                          "httpGet": {
                            "port": null
                          }
                        },
                        "image": null
                      },
                      "name": null
                    }
                  ],
                  "osType": "Linux",
                  "restartPolicy": "Never",
"volumes": [
          {
            "azureFile": {
              "shareName": null,
              "storageAccountName": null
            },
            "gitRepo": {
              "repository": null
            },
            "name": null
          }
        ]
                }
              },
              "path": "/subscriptions/@{encodeURIComponent('abc')}/resourceGroups/@{encodeURIComponent('abc')}/providers/Microsoft.ContainerInstance/containerGroups/@{encodeURIComponent('aaa')}",
              "queries": {
                "x-ms-api-version": "2019-12-01"
              }

Screenshots or Videos

Screenshot 2024-07-08 at 9 38 14 AM

Browser

Chrome, Edge

Additional context

To correct the issue you need to go into code view and deleting the unneeded keys. However, if you do this the New Designer will no longer show the pretty/detail inputs view of the various values and only shows the raw json view instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eric-B-Wu Eric-B-Wu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mlee78 @Eric-B-Wu